http://pastebin.com/ekrmgBgy

Upon placing a Better Storage crate next to a hopperhock I received this crash in a singleplayer world. With the latest GOG pack with Garden of glass mod disabled.

It appears to be betterstorage's fault, NOT botania.
On Wed, Jan 6, 2016 at 2:03 PM KillerRamer [email protected] wrote:

http://pastebincom/ekrmgBgy

Upon placing a Better Storage crate next to a hopperhock I received this
crash in a singleplayer world With the latest GOG pack with Garden of glass
mod disabled

—
Reply to this email directly or view it on GitHub
#1718.

crash is caused by better storage yes but it's crashing because botania is calling inventory methods on the client and that shouldn't heapen, all inventory code should only be executed on the server side

I'll look up how inventories are supposed to work, and if they need to be server only I'll send a pr, but my gut tells me the betterstorage method shouldn't be throwing unchecked exceptions when it can easily recover

client side should only be rendering related, logic should be server side

also for reference: BCA-Team/Buildcraft-Additions#460

Looking at it, the crash isn't caused when we put an item into the BS crates inventory (which btw is done only on the server side, see SubTileHopperhock.java#L115-L128).

Its actually before that point, the crash occurs when we test to see if an item can be inserted into an inventory (see SubTileHopperhock.java#L95).

This should just need a check adding in here to make sure this is only done on the server.

Closed by bf55ee4