TileSpecialFlower logic is broken for enchanted soil
SquidDev opened this issue · 2 comments
The checks for enchanted soil are broken, meaning overgrowthBoost
will always be false and onUpdate
is executed twice. It should probably be:
boolean special = isOnSpecialSoil();
boolean special = isOnSpecialSoil();
if(special) {
subTile.overgrowth = true;
subTile.onUpdate();
if(subTile.isOvergrowthAffected())
subTile.overgrowthBoost = true;
} else {
subTile.onUpdate();
subTile.overgrowth = false;
subTile.overgrowthBoost = false;
}
No, that looks right to me...
On Thu, Jan 7, 2016 at 5:57 AM SquidDev [email protected] wrote:
The checks for enchanted soil
https://github.com/Vazkii/Botania/blob/master/src/main/java/vazkii/botania/common/block/tile/TileSpecialFlower.java#L93-L103
are broken, meaning overgrowthBoost will always be false and onUpdate is
executed twice. It should probably be:boolean special = isOnSpecialSoil();
boolean special = isOnSpecialSoil();
if(special) {
subTile.overgrowth = true;
subTile.onUpdate();
if(subTile.isOvergrowthAffected())
subTile.overgrowthBoost = true;} else {
subTile.onUpdate();
subTile.overgrowth = false;
subTile.overgrowthBoost = false;
}—
Reply to this email directly or view it on GitHub
#1720.