Botania

Botania

133M Downloads

Lexica Botania Hand Render Glitch on 1.7.10

Opened this issue ยท 24 comments

commented

Holding a Lexica Botania in your hand under 1.7.10 makes the text on the front, well...

Log: https://gist.githubusercontent.com/blue42u/b2b52b7baa348cae1e27/raw/a7d11fa89d661649bda96f3a610fc396d82a4d85/fml-client-latest.log

commented

Looks fine here. Logs please.

commented

Always forgetting something...

commented

Can you get this to happen without any other mods? I'm assuming one of them is messing up, as it renders fine for me.

commented

Hm. This is really weird, might be related to forge. I'll see if anyone else can reproduce it.

commented

I cant reproduce it either, using forge 91 and botania 96

commented

Try rolling back to see which version is the first one to cause issues, then it'll be easy to check the modified code and pinpoint the issue.

commented

Been bisecting using the builds: I can't see the text on build 50 and below, and it's like in the pic on 51 and above. Will do commit-based bisecting tonight.

commented

The text was added in 51. A while back. As I said, it might be a change in forge, are you using the very latest?

commented

Yeah, 10.13.0.1191.

commented

Try 1180.

commented

Nope. Still the same. I'll close this until I can do some more advanced testing.

commented

Dammit, I accidently deleted a comment, whoever it was (can't remember the username), please place it back since it was useful, sorry for that :|

commented

Got it from my email:
@adudney
Happens for me on Botania 96, Forge 10.13.0.1190, Mac OS 10.9.4, Java 1.7.0_55. With just Botania and Baubles installed

commented

Anyway, back on track, yours doesn't render at all, which is also quite interesting, is it only because of the ice?

commented

Nope, it's never rendered for me on any version anywhere.

commented

Hm, I see. Ok, flagging it as a proper bug, will have a look at it sometime.

commented

I think #221 might just fix it, I'll pull it down and test.

commented

2014-08-03_12 25 48
Yup, #221 fixes it for me.

commented

Isn't that 2 separate bugs? For @blue42u it's offset and upside-down, and for @adudney it's not there at all.

commented

Windows works fine. Also, LWJGL should be platform independent... And "rotation command" is a pretty basic thing, can't see how am implementation could screw it up and no one would notice until a random MC mod bug...
That just might be the case actually... The original code is rotating by a zero vector, which is undefined, and it's probably causing the bug. The input is automatically normalized, which would produce either floating point issues, infinity, or just set it all to 1,and I don't think it's what was intended.

commented

I think it's 2 different manifestations of the same bug, seeing as how I'm on a Mac and @blue42u is on Linux, it's probably just the different opengl implementations handling the rotation command differently.

commented

Precisely, it's not the case that the defined rotations are acting differently, it's the case that the 0 vector is causing undefined behavior which varies between platforms.