Tainted Blood Pendant can be powered by a Band of Aura
tofof opened this issue ยท 1 comments
Expected Behavior
A tainted blood pendant with fleetfoot (speed II) costs 60 mana/sec (more accurately 3 mana/tick) - quite a bit more than even a greater band of aura (+10 mana/sec) should be capable of providing.
Observed Behavior
This combination (plus an empty mana tablet or band of mana) provides the buff 100% of the time; the tablet stays between 0-5 mana (99.9% empty) but the potion effect never fails to renew.
Steps to Reproduce
- Equip a tainted blood pendant with fleetfeet.
- Equip a band of aura or greater band of aura.
- Equip an empty band of mana.
You now have Speed II, without having ever had enough mana to power it for even a second in the tablet. - Throw the band of mana on the ground.
You lose Speed II. - Pick up the band of mana.
You gain Speed II.
Explanation
Watching the band of mana's NBT data in game makes the cause apparent.
Starting at 0 mana, it gains from the band of aura's effect, quickly going to 1, 2, 3, 4 mana....
At which point, the tainted blood pendant sees that the amount of available mana (4) is greater than the amount it wants to withdraw in a single tick (3). So it does so, and applies the potion buff for 4 seconds.
The mana immediately climbs up for several ticks until it's large enough again, at which point it drops down from the tainted blood pendant again.
In this way, the blood pendant only actually withdraws mana on something like 1 of 7 ticks, even while the potion is active.
Suggested Fix
The tainted blood pendant should require payment upfront (prepayment) for the entire 4 second potion effect. In other words, withdraw 240 mana every 80 ticks instead of withdrawing 3 each tick. With an empty tablet, the potion effect would be applied only once during each 24 second cycle, and the player would gain the buff only 1/6th of the time (as expected for the -60 vs +10 rates).
Mod Pack: Skyfactory 3
Minecraft: 1.10.2
Botania: r1.9-341
