Azanor change API in Baubles

Question

Azanor change API in Baubles

Rumaruka opened this issue 7 years ago · 16 comments

Rumaruka commented 7 years ago

Crash log : https://pastebin.com/FLr25HjU
Minecraft 1.11.2

williewillus commented 7 years ago

^

Vazkii · Answer 1 · 2017-08-03T18:15:36.000Z

@Azanor mate come on don't go breaking backwards compatibility like that :|

Rumaruka · Answer 2 · 2017-08-03T18:18:12.000Z

@Vazkii :(

Azanor · Answer 3 · 2017-08-04T05:54:53.000Z

Not sure what you mean - those are new additions and should not break backwards capability at all.

Azanor · Answer 4 · 2017-08-04T13:05:18.000Z

Maybe there is another mod that has the api source in its code and it is being used over the newer code in the baubles .jar?

Vazkii · Answer 5 · 2017-08-04T13:15:07.000Z

Yeah, this would probably have to be tested in isolation.

…

On Fri, Aug 4, 2017, 14:05 Azanor ***@***.***> wrote: Maybe there is another mod that has the api source in its code and it is being used over the newer code in the baubles .jar? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2324 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABtir7r6jSlwilGhfTfID3V4vMxSjLJrks5sUxcOgaJpZM4Osubf> .

016Nojr · Answer 6 · 2017-08-04T14:48:56.000Z

Could it be Actually Baubles? Try removing that @Rumaruka

Rumaruka · Answer 7 · 2017-08-04T16:05:42.000Z

@016Nojr Nope, Im downgrate Baubles and WORKING

Vazkii · Answer 8 · 2017-08-04T12:32:05.000Z

I've had a look at your code, and yeah, it's impossible for this error to actually happen. I'm officially confused.

…

On Fri, Aug 4, 2017, 06:55 Azanor ***@***.***> wrote: Not sure what you mean - those are new additions and should break backwards capability at all. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2324 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABtiryOTfpmld3ybFHH5cIC0u3e6Ggnxks5sUrItgaJpZM4Osubf> .

williewillus · Answer 9 · 2017-08-04T21:22:59.000Z

@Rumaruka can you reproduce this with just new baubles and botania?

JackyyTV · Answer 10 · 2017-08-04T16:58:22.000Z

My mod (Actually Baubles) shouldn't be causing this crash as it depends on Baubles as well.
Plus, the 1.11.2 Actually Baubles build was compiled based on Baubles 1.4.6 (which is the version in the crash report) and I've tested that build before releasing it.

TehBlizzy · Answer 11 · 2017-08-06T18:27:29.000Z

I would like to add that I am receiving this crash as well after I updated a modpack to the latest versions. Creating a new profile and only adding the latest Baubles and Botania works perfectly fine. I'm going to add/remove mods down my list to see what could be interfering with it and edit this with any update(s).

IchigoGames · Answer 12 · 2017-08-07T23:03:00.000Z

Happens with Baubles-1.11-1.4.6 does not happen with Baubles-1.11-1.4.5 so something changed and its crashing now im just not going to update Baubles for now when i update my pack.

IchigoGames · Answer 13 · 2017-08-14T06:17:02.000Z

anyone know if baubles will come out with a fix ?

Xalcon · Answer 14 · 2017-08-15T06:53:08.000Z

@Rumaruka is your modpack publicly available? I would like to do some tests. For me it looks like there is a mod in your pack that ships with an outdated Baubles-API package. The API Package doesnt contain a Mod definition - therefore forge cant check the version.

@everyone-else:
This is not an issue with botania itself. If I'm right, botania doesnt need to fix anything to get this working. Its just botania being the first mod accessing the API and causing the crash :/ We need to find the mod that ships with the old API and fix that.

General idea: I'm not super good with reflection but would it be possible to get the jar a given class is loaded from?

Xalcon · Answer 15 · 2017-08-15T07:42:19.000Z

Okay, good news everyone. I found the offending Mod, its NineTailsLib (a ProjectX 2 dependency)
https://minecraft.curseforge.com/projects/ninetaillib?gameCategorySlug=mc-mods&projectID=264381
https://github.com/TeamMD5/NineTailLib/tree/1.11.2/src/main/java/baubles/api

You can easily reproduce the issue with the following mods installed:

Botania
Baubles
ProjectX 2
NineTailsLib
CodeChickenLib

Share to