Version Information

Forge version: 28.1.107
Botania version: r1.11-373

Further Information

Steps to reproduce:

1. place a loom
2. put a banner into the loom
3. put dye into the loom
4. try putting a iron pickaxe into the loom

What I expected to happen: I expected to be able to put that Pickaxe into the loom and get a Banner with a Pickaxe patter on it.

What happened instead: I couldn't put the Pickaxe into that loom.

forge issue

I kinda suspected that but as it didn't logs the error the forge code contains i wasn't sure if its really that or something else, thanks.

The forge bug for reference: MinecraftForge/MinecraftForge#6040

Thanks.
It seems to be due to this(BannerPattern.java.patch#L17), i just wasn't sure that is what causes it because the exception that gets thrown there doesn't seem to go anywhere.

That's not the issue, the method you linked is replaced at runtime by a class transformer like in every extensible enum.

Mojang calls values().length for a final field in that class and uses that value in the loom gui, which causes ArrayIndexOutOfBoundsException to be thrown if you insert that pattern.

OK i didn't know that, but why doesn't Botania get that Exception than?
If i try to put the Pattern in it just doesn't works but doesn't cause a exception to get to the log.

Mojang entirely removed the "craft banner with pattern in a crafting table" method in favor of the loom.

I meant if i try to put the "Pattern" item in the loom, not to craft it in the crafting table :)

Ah, that type of pattern. That thing is actually completely ignored now, and the actual banner pattern items are the only thing accepted in the loom gui, and if you try to add your own, it crashes when used.

This is getting quite spammy, you should really join Vazkii's discord :V

I might do that