Botania

Botania

133M Downloads

Refactor delays to not use item ages

williewillus opened this issue ยท 1 comments

commented

Right now, Botania overloads vanilla's age tag for item entities for its own purposes, such as delaying when items are picked up by flowers. This has caused numerous bugs and very fragile code and magic-constant heavy code throughout the years. Example. Holy magic constants!

We should port this to a separate variable/tag and migrate all overloads of age to it. Additionally, magic checks such as the above should be pulled into a util class with clear names and documentation, if necessary. Will require extremely careful testing to make sure no behavioural changes are made.

commented