Stacked mana items multiply/divide mana on transfer
abint opened this issue ยท 4 comments
Version Information
Forge version: 36.0.13
Botania version: 1.16.4 - 411
Further Information
Steps to reproduce:
- Store a mana containing item in a way that compresses it to stack
- Drop item stack onto a mana pool with mana
- Change mode of mana pool to either fill or extract from item accordingly
Practical steps:
- Make a couple of mana tablets
2a. Put mana tablets in a dank from the dank storage mode to compress it
3a. Take out the mana tablets by hand
4a. Drop mana tablet stack into pool
2b. Put mana tablets in a regular storage
3b. Use integrated dynamic's world item exporter to export an exact stack of any amount of tablets greater than 1
What I expected to happen:
The pool sees the item stack and either splits mana between the items in the stack or the pool ignores the stack refusing to use it.
What happened instead:
The entire stack is treated as a single item, changing the mana NBT of the whole stack. This allows for you to duplicate mana by filling empty stacks, and splitting full stacks.
Shouldn't other mods not be stacking items that we explicitly say are not stackable?
Stacked items appear as a single item entity to the pool, and operations on stacked items operate on the whole thing usually (see what happens in vanilla when you anvil stacked items). I'm not super keen on adding code to fix other people's poorly balanced features.
Honestly, I think making stacked mana containers do nothing might be the best solution. Are there any addons that actually wanted stackable mana items?
I reported it here because of how omnipresent mods are that allow you to stack higher than default in packs, and this was the most common point. It's quite a gamebreaking exploit that allows you to skip all mana gen past endoflames. I don't know how hard it would be to check the NBT tag of an item and see if its a Count:1b as I'm no programmer