[Mod Incompatibility] Some items don't work with Better Combat

Question

[Mod Incompatibility] Some items don't work with Better Combat

bassistracer opened this issue 2 years ago · 7 comments

bassistracer commented 2 years ago

Mod Loader

Fabric

Minecraft Version

1.18.2

Botania version

1.18.2-435

Modloader version

0.14.9 + API 0.58.0

Modpack info

No response

The latest.log file

N/A

Issue description

When paired with Better Combat, the swinging animations for Better Combat do not allow weapons (like the Terra Blade, basically any weapon with a projectile) to fire its projectile. This doesn't seem to be an issue with Better Combat itself, as for example, Simply Swords's Chakram allows you to toss it while still using Better Combat animations.
Not exactly sure if this belongs here. If not, sorry.

Steps to reproduce

Download Botania & Better Combat
Let Better Combat's Fallback Compatibility apply to the Botania weapons (should be done by default)
Get a Terra Blade and swing it to test it

Other information

https://www.curseforge.com/minecraft/mc-mods/better-combat-by-daedelus

Warhand · Answer 1 · 2022-10-06T16:35:36.000Z

Iirc this is actually an issue with better combat, since better combat cancels the left click event, which is what botanias weapons use to know when they should do their effects on attack

Dr-WeiAL · Answer 2 · 2022-10-07T00:01:56.000Z

Iirc this is actually an issue with better combat, since better combat cancels the left click event, which is what botanias weapons use to know when they should do their effects on attack

But if the melee hit the target will fire its projectile, feeling that this problem can only be compatible by Botania

Dr-WeiAL · Answer 3 · 2022-12-17T15:53:18.000Z

ok, thanks

I found the problem, although the Terra Blade projectile is normal, but Starcaller does not summon meteors
So this issues may have to be reopened

Dr-WeiAL · Answer 4 · 2022-12-11T08:36:56.000Z

I found that this problem has been solved, probably because BetterCombat has made changes to the attack method, in any case, you can launch the projectile normally

williewillus · Answer 5 · 2022-12-11T17:58:53.000Z