Botania

Botania

133M Downloads

[Bug][1.19.2] Bubbell refills air bubble even if it is impossible for it to do so, and strange behavior with plant blocks

FizzBuzz3000 opened this issue ยท 2 comments

commented

Mod Loader

Fabric

Minecraft Version

1.19.2

Botania version

Botania-1.19.2-436-FABRIC.jar

Modloader version

fabric-api-0.70.0+1.19.2 fabric-0.14.13

Modpack info

No response

The latest.log file

https://cdn.discordapp.com/attachments/977270876200386620/1066507597009666129/wateryoudoingbubell.webm

Issue description

The bubbell can refill air bubbles with water it created, even if it is not possible for the water to fill back in. (i.e. blocks that prevent water from flowing back in).

Another bug is that plant blocks (saplings, (tall) grass, botania's flowers) cannot be planted along of the edge where the bubbell stops pushing water back. water flows in and breaks the plant. I do not know if anything can be done about this, and wouldn't be surprised if it can't.

Steps to reproduce

No response

Other information

No response

commented

From reading the code, this seems intentional (any decaying fake air block has a 10% chance to become water).

That being said, the Bubbell could do with a redesign in general.

commented

Another bug is that plant blocks (saplings, (tall) grass, botania's flowers) cannot be planted along of the edge where the bubbell stops pushing water back. water flows in and breaks the plant. I do not know if anything can be done about this, and wouldn't be surprised if it can't.

I don't think there's a good way to prevent flushable blocks from being flushed away at the edge of the water-blocking air bubble. The reason water can't flow into the bubble is because it consists of special blocks that block water flow. Saplings would replace that block and allow water to flow in again.

The Bubbell also seems ignorant to being moved (e.g. with Quark's or Carpet's MBE option) and its fake air blocks hare hard-wired to a single flower, even if there may be two of them with overlapping areas of effect.

That being said, the Bubbell could do with a redesign in general.

When you say "redesign" what kind of scope did you have in mind?