Botania

Botania

133M Downloads

Ender Air Bottling Interaction blocks bottle block interactions in the End

DaFuqs opened this issue ยท 1 comments

commented

Mod Loader

Fabric

Minecraft Version

1.19.2

Botania version

1.19.2-436

Modloader version

Any

Modpack info

No response

The latest.log file


Issue description

The ender air bottling logic is implemented via UseItemCallback.EVENT.register(EnderAirItem::onPlayerInteract);. It returns sucess() if the player is in the End and no dragon breath would be picked up.

Returning pass at this stage will skip any bottle on block interaction, since the interaction has already been handled, preventing players to interact with blocks using a bottle in the end (like bottling fluids).

A suggested fix would be to only collect Ender Air is the player is not targeting a block, while otherwise calling pass().

Steps to reproduce

  1. Go to the End
  2. Right Click with a bottle anywhere that is not near dragon's breath (in the air, on water, on stone, ...)
  3. You get Ender Air

Other information

No response

commented

Issue also exists on Forge. However, on both platforms it only applies to bottling water. Interaction with e.g. bee hives works fine since that's a separate event that fires before Botania's ender air pickup attempt.
Might be a relatively simple fix by also checking whether the player targets a fluid.