Botania

Botania

133M Downloads

Trinkets Integration for Botania Fabric's "Trinket Box" is missing

Shibva opened this issue · 2 comments

commented

Mod Loader

Fabric

Minecraft Version

(varies as long as Trinkets has existed in X versions) [19.2 if you want to be specific]

Botania version

19.2-440

Modloader version

farbic 0.14.21

Modpack info

No response

The latest.log file

(is not a error from what I gathered)

Issue description

I've noticed that in the Farbic version of Botania that some of the trinkets from other mods should go into the Trinkets Case won't and after looking into your code here, I've realized its because only Curios integration was made.

Considering that your trinkets have trinket integration for being used in the Trinket slots, I can only assume that this was most likely an oversight or something that was forgotten to be added to the isAccessory check when implementing compatibility with Trinkets (the mod) for Botania Farbic.

Steps to reproduce

No response

Other information

This hopefully is a simple thing to correct; having it check for any item that has tag added by Trinkets should do the trick for covering for Trinkets items and any other mod that adds items that uses Trinket slots

commented

@williewillus sorry about that… I don't remember making a second report of this. Of course the name is different so I might've accidentally submitted a second time when making edits on the first somehow.

I say this as a contents of both report for nearly one for one matches

commented

OH BOY

thanks man ❤️