Mod Loader

Both Fabric and Forge (I confirm that I have tested both loaders and will specify both loader versions below)

Minecraft Version

1.17+

Botania version

1.19.2-440

Modloader version

(any)

Modpack info

No response

The latest.log file

(n/a)

Issue description

Code analysis of the DrumBlock revealed some deficits in the handling of animals by the Drum of the Gathering:

• Cows do not need to be adults to be eligible for milking.
• Brown mooshrooms have no special handling, so milking them with a bowl always only produces mushroom stew. If under the effect of a flower previously fed to the mooshroom, it should produce suspicious stew instead.
• Goats are ignored for milking, as only entities extending net.minecraft.world.entity.animal.Cow can be milked. There are also modded animals (e.g. yaks) where both shearing and milking could make sense. (But while mooshrooms are both milkable and shearable, any code changes should still only consider them for milking to prevent reverting them to regular cows.)

Steps to reproduce

No response

Other information

Proposed changes:

• Keep special handling for filling bowls from mooshrooms and extend it to support suspicious stew.
• Generalize milking with an entity tag (e.g. botania:gathering_drum_milkable), which includes cows, goats, red mooshrooms and brown mooshrooms by default.
• Define a Shearable entity exclusion tag (e.g. botania:gathering_drum_no_shearing), which prevents shearing red and brown mooshrooms by default.

To fully automate suspicious stew production, the Pollidisiac flower's functionality could also be extended to feed stew flowers to brown mooshroom that don't have a flower effect yet.