Mod Loader

Forge

Minecraft Version

1.19.2

Botania version

1.19.2-440-FORGE

Modloader version

Forge 43.3.2

Modpack info

Create: Prepare To Dye: https://modrinth.com/modpack/create-prepare-to-dye

The latest.log file

https://flist.petra-k.at/p/lv9A1F.log

Issue description

Create Deployers can't bottle ender air from the cloud created from purifying end stone with a pure daisy.

I've used F3+B to make sure that it is actually interacting with the space where the air entity is.

Given that a player right-clicking can bottle the air, I think it would make sense if deployers could also do it. (I could do this with dispensers, but it would be harder.)

Steps to reproduce

1. Place a Pure Daisy on the ground
2. With a two or three block gap between the ground, place a deployer facing down. At three blocks, the block the deployer interacts with is the block above the deepslate, which is where the entity spawns (according to F3+B)
3. Place an end stone by the pure daisy
4. Wait a minute
5. Observe that the ender air entity is spawned but not picked up by the deployer.

Other information

Can confirm, ender air pickup code is weird and should probably be based on actually interacting with the entity instead of being near it.

Aha, this appears to be the problem:

https://github.com/VazkiiMods/Botania/blob/1.20.x/Xplat/src/main/java/vazkii/botania/common/item/material/EnderAirItem.java#L52C20-L52C20

The hitbox for picking up the ender air is the player's hitbox expanded by an amount, and doesn't account for where the player is aiming at all. I'm not sure how the deployer fakeplayer's hitbox works, but from my experiments summoning the entity a lot of places it looks like whatever it's doing it can't ever pick up the air.