Add Firel's tracks to Botania/GoG
williewillus opened this issue ยท 1 comments
Mod Loader
Both Fabric and Forge (I confirm that I have tested both loaders and will specify both loader versions below)
Minecraft Version
Botania version
Modloader version
Modpack info
No response
The latest.log file
N/A
Issue description
Just a tracking todo.
Add Firel's three tracks https://github.com/VazkiiMods/BotaniaCD/tree/main/audio to the game.
Should be able to do this without any code by just adding them to the assets/botania/sounds/music folder, then adding a assets/minecraft/sounds.json in our datapack that adds the music into the music.game sound event.
The GoG track should be added to the GoG mod instead under assets/gardenofglass.
Make sure to add to credits on the website.
Maybe also consider adding music disc items, but that's not strictly in the scope of this task.
Note that if music discs are added, the tracks need to be downmixed to mono (if they're stereo) so positional audio works properly.
Steps to reproduce
No response
Other information
No response
Progress/preparation update: I did a couple of compression tests, hoping to get versions with reasonable quality. I went for the stronger end of the compression ratios first, which would help if both an ambient music and disk version should be included. (The gaia fight music could probably benefit from that treatment, but not sure if we want disk versions of the GoG/Runes tracks. If not, and quality of the stereo versions is not sufficient, I'll bump up the target quality at the expense of not including a disk version.)
Temporarily, for the purpose of letting others check the audio quality, I host the files on my web space: (There's no browsing, missing or incorrect file names will result in HTTP 403 or 404 errors.)