Botania

Botania

Mods
133M Downloads

In certain modded environments, all loot tables appear to be empty

unilock opened this issue · 5 comments

commented

Mod Loader

Quilt (possibly also Fabric)

Minecraft Version

1.20.1

Botania version

1.20.1-443

Modloader version

Quilt Loader 0.23.0 + QFAPI 7.4.0 / Fabric API 0.90.0

Modpack info

N/A

The latest.log file

https://gist.github.com/unilock/102676f783706c3df48a78b89980b897

Issue description

Under very certain conditions (namely, the exact set of mods installed), all loot tables appear to be empty - blocks drop nothing, slain mobs drop nothing, etc.

Steps to reproduce

  1. Install Quilt Loader 0.23.0
  2. Install the exact set of mods listed below
  3. Start the game, create a new superflat world in survival mode with cheats enabled
  4. Try breaking a Grass Block by hand; nothing is dropped
  5. /give <username> minecraft:netherite_sword
  6. /summon minecraft:sheep
  7. Kill the Sheep with the Netherite Sword; nothing is dropped

Other information

This issue does not occur reliably across all modded environments; rather, it seems dependent on which mods are installed at the time. I suspect this is due to the mod loading order being semi-random on Fabric / Quilt; I'm guessing it's deterministic based on the current mod set. My theory is that some loot-related mixin is being applied before / after some other loot-related mixin in an incompatible manner, ultimately causing the issue.

Due to this issue being so random, it's been very difficult to narrow down the mod set to only those related to the issue. Here is the smallest set of mods I've been able to reproduce the issue with thus far:

Mods marked with a * are noted to have a mixin targetting net/minecraft/world/level/storage/loot/LootTable (Mojmap) / net/minecraft/loot/LootTable (Yarn).

I'm fairly certain this issue is caused by, or at least related to Botania, as removing Botania results in the issue resolving itself, even after several other changes to the mod set.

commented

Fixed on Porting Lib's end.

  • 👍1
commented

I have had issues with porting_lib in the past - my understanding is it drastically changes the vanilla loot system. Does this happen without it?

commented

Removing Porting Lib (and all mods that depend on / embed it) does also appear to "fix" the issue. However, it's used by quite a few large mods in the modpack I'm working with, so removing it is not much of an option, in my case.

This leads me to believe that this is an incompatibility between Botania and Porting Lib. That being said, I believe this specifically affects Quilt (Loader / API), as I have in the past used a Fabric-based 1.20.1 modpack with Botania and Porting Lib without ever encountering this issue.

Although... another Fabric-based 1.20.1 modpack, All of Fabric 7, appears to have also had this issue after adding Botania and Create (and thus Porting Lib): TeamAOF/All-of-Fabric-7#66
...but I guess it's since been resolved? I have no idea what they might've done to fix it, though...

commented

I wonder if it's to do with the chest loot injects Botania does?

commented

I checked All of Fabric's Discord guild, and apparently this is a recurring issue - though it seems to only occur after their AOF7 server(s) have been running for a while (instead of immediately), and is usually fixed by restarting the server. Neither is the case for me...

Links to some relevant messages in the Discord guild: 2024-01-07, 2024-01-04, 2024-01-04, 2023-12-31 (with some relevant discussion)