Botania

Botania

133M Downloads

Corporea Crystal Cube forgets its item in some locations of the world

TheRealWormbo opened this issue ยท 1 comments

commented

Mod Loader

Both Fabric and Forge (I confirm that I have tested both loaders and will specify both loader versions below)

Minecraft Version

1.20.1

Botania version

444

Modloader version

(any)

Modpack info

(none)

The latest.log file

(n/a)

Issue description

In certain locations, the Corporea Crystal Cube appears to forget about its item when it is reloaded. Before a reload, /data get block <coords> shows the appropriate block entity data, afterwards it lists the cube as not having a requestItem.

There appears to be some sort of pattern to the data loss locations:
16x16 plane of cubes
subchunk outline-ish of cubes

Steps to reproduce

  1. Place Corporea Crystal Cube.
  2. Use any item on the cube.
  3. Unload the chunk.
  4. Load the chunk again. If the cube is in an affected location, it will have forgotten the item type set in step 2.

Other information

No response

commented

Upon further inspection, it's likely the CorporeaCrystalCubeBlockEntity never marks itself as changed and thus relies on another block entity to mark the subchunk as requiring a save. Could potentially be related to an old performance optimization, referencing #734.