With Porting Lib, terrasteel will crit effects always happen
Partonetrain opened this issue ยท 3 comments
Mod Loader
Fabric
Minecraft Version
1.20.1
Botania version
1.20.1-443
Modloader version
Fabric 0.15.10
Modpack info
No response
The latest.log file
n/a
Issue description
When Porting Lib 2.3.4 is installed with Botania-1.20.1-443-FABRIC, the Terrasteel Will crit effects will always happen on hit.
Steps to reproduce
- install Porting Lib and Botania
- Craft Terrasteel Helmet with obvious crit effect will
- normally hit something
Other information
Porting Lib issue: Fabricators-of-Create/Porting-Lib#103
As far as I can tell, PortingLib injects a bunch of code into Player::attack, some related to return values of isSprinting(), which I assume hits Botania's injected call to that method (and always returns true) instead of the intended one.
I never would've guessed this was what caused this. I noticed this but couldn't tell what caused it. Can confirm this happens to me using both mods as well. Hopefully this can be fixed.