Lighting incense plates does not use the tool action
ChiefArug opened this issue ยท 3 comments
Mod Loader
Forge
Minecraft Version
1.20.1
Botania version
1.20.1-448
Modloader version
Forge 47.4.2
Modpack info
No response
The latest.log file
N/A
Issue description
The incense plate does not use the tool action for lighting fires and instead hardcodes it to the vanilla flint and steel, so modded flint and steel like tinkers flint and brick cannot light it.
Steps to reproduce
Use a flint and brick from tinkers construct to light an incense plate.
Fail and instead end up picking up the incense stick
Other information
The relevant ToolAction: https://github.com/SlimeKnights/TinkersConstruct/blob/455d6ae556084928f40cff0a00e63a462aed900f/src/main/java/slimeknights/tconstruct/tools/modifiers/ability/interaction/FirestarterModifier.java#L60 (due to how tool actions work you can just have this in your own field and it will link to the same instance tinkers has).
To check if an item can perform an action use IForgeItemStack#canPerformAction.
Is there a corresponding report on the Tinkers repository? Because I'm somewhat sure this will require more than just checking the tool action. A broken tool should not perform this action, for example, but I'm not even sure Botania would know when a Tinkers tool is broken, because that's not a state items other than the elytra could be in.
For reference: We already have another Tinkers-related bug where Tinkers' reimplementation of attack behavior does not work with Terrasteel helmet wills. This may or may not be fixed in 1.20.1 anymore.
This is entirely an issue on Botania's end.
Tool actions are item stack sensitive (read: nbt sensitive. otherwise you would just use item tags), so Tinkers can handle returning false for broken tools that are unable to perform their actions. I suspect this is already the case and if its not then a bug report can be made to Tinkers when that is discovered.