Botanist's Toolbelt
yrsegal opened this issue · 32 comments
@L0neKitsune, this is having trouble. Could you take a look? it's slightly idiosyncratic behavior
I'm guessing its the fact that its not dropping the items. Also I hate you for making me choose this over the sash. You did an awesome job on it.
It's having issues where the stack only SOMETIMES goes into the belt for real, but it visually does it whether or not it went in. Assembly/Manufactory halos have dupe bugs.
Sounds like the dupe bugs with the hopper. I think I know where to look for that.
Well I can say its a sided issue. If you interact with the players inventory on remote it won't properly remove the block.
@yrsegal I fixed a putting items in, taking them out is still not working. It looks like if you try to take the item out on the client it won't find the item, but if you take it out on the server it cant add the item to the players inventory, you get a ghost item.
Ill take a look at it tonight after I think it over some more, if you haven't fixed it by then.
Ok, thank you.
On Sun, Jan 10, 2016 at 4:17 PM Crowe [email protected] wrote:
@yrsegal https://github.com/yrsegal I fixed a putting items in, taking
them out is still not working. It looks like if you try to take the item
out on the client it won't find the item, but if you take it out on the
server it cant add the item to the players inventory, you get a ghost item.Ill take a look at it tonight after I think it over some more, if you
haven't fixed it by then.—
Reply to this email directly or view it on GitHub
#54 (comment)
.
I think I'm going to need to write a packet handler for this.... I need to look at gui code more tomorrow if I get the chance.
@yrsegal For some reason that utterly astounds me.
you should see v's packet code, it's amazing it works at all https://gist.github.com/Vazkii/13e0ce45577bbae49362
Reminds me of the preferences class my coworker wrote for android. It was a remarkably elegant solution to a pain in the ass problem. I think I did a fairly good job since I pulled it out of my ass during a 15 min break :P
It's impressively efficient and small.
On Mon, Jan 11, 2016 at 9:01 PM Crowe [email protected] wrote:
Reminds me of the preferences class my coworker wrote for android. It was
a remarkably elegant solution to a pain in the ass problem. I think I did a
fairly good job since I pulled it out of my ass during a 15 min break :P—
Reply to this email directly or view it on GitHub
#54 (comment)
.
Yea its well done, I'm surprised that it works as well. The problem is similar to the preferences problem and me and the other two senior devs gave up on it in java. I'm half tempted to rewrite V's solution in kotlin kinda like this https://gist.github.com/L0neKitsune/45eba657cfa551ff862f
Actually its pretty ingenious to use a HashMap and reflection like that. I may write a class for preferences that extends off of this idea for our java projects...
It is really damn genius. V is crazy good.
On Mon, Jan 11, 2016 at 9:16 PM Crowe [email protected] wrote:
Actually its pretty ingenious to use a HashMap and reflection like that. I
may write a class for preferences that extends off of this idea for our
java projects...—
Reply to this email directly or view it on GitHub
#54 (comment)
.
One warning: this is J1.8-requiring.
On Mon, Jan 11, 2016 at 9:17 PM Wire Segal [email protected] wrote:
It is really damn genius. V is crazy good.
On Mon, Jan 11, 2016 at 9:16 PM Crowe [email protected] wrote:Actually its pretty ingenious to use a HashMap and reflection like that.
I may write a class for preferences that extends off of this idea for our
java projects...—
Reply to this email directly or view it on GitHub
#54 (comment)
.
@yrsegal Give the latest code I pushed a test. Hopefully it works, I didn't have time on my break to test to see if it works.
Hey guys, got a question for you regarding the belt after watching L0ne's vid, it looks like your using sneak as the trigger for the rendering, is this gona stay hardcoded or be made into a bindable hotkey, as a problem I forsee straight away is how are you going to deal with anything that requires shift-clicking when you are wearing the belt (e.g. Storage Drawers, JABBA Barrels, Wand of the Forest etc), because atm the render will pop up when you are trying to interact with something else.
I've been playing around with it in my dev survival world, it feels
intuitive and unobtrusive enough.
Also, isn't key binding against V's philosophy?
On Wed, Jan 13, 2016 at 4:42 AM Jonathan Smith [email protected]
wrote:
cool, thats good, thought I'd point it out in case it had slipped through
the gaps.Though as a suggestion, I'd like to request it be bindable, as I'd
probably want to change it to another button than shift [image:
😝]—
Reply to this email directly or view it on GitHub
#54 (comment)
.
cool, thats good, thought I'd point it out in case it had slipped through the gaps.
Though as a suggestion, I'd like to request it be bindable, as I'd probably want to change it to another button than shift 😝
You can always download this, throw in the dependencies (FMP, NEI,
Thaumcraft, Botania, and associated libraries), and check it out for
yourself. :P
On Wed, Jan 13, 2016 at 9:06 AM Jonathan Smith [email protected]
wrote:
tis so, I'll have to give it a go once u release it and get used to it [image:
😄]—
Reply to this email directly or view it on GitHub
#54 (comment)
.
or just clone the repo and load it into the dev env where I have the stuff, depends whichever i can be arsed to do lol
True :3
You would have to set up Kotlin in said env, though.
On Wed, Jan 13, 2016 at 9:09 AM Jonathan Smith [email protected]
wrote:
or just clone the repo and load it into the dev env where I have the
stuff, depends whichever i can be arsed to do lol—
Reply to this email directly or view it on GitHub
#54 (comment)
.