Botany Pots

Botany Pots

33M Downloads

Big lag

Technici4n opened this issue ยท 1 comments

commented

Hi,

The AOF6 folks have found some big lag caused by Botany Pots and a Modern Dynamics pipe setup. Here's a picture of the setup:
image

This looks like a bad interaction with the Fabric Transfer API and its transactional system, causing lots of markDirty calls. If you can expose InventoryStorage.of(your SimpleContainer) instead of relying on the basic Container wrapper, the markDirty calls will be skipped (Fabric has special interaction with SimpleContainer to skip markDirty in setItem inside of a transaction). There are probably other fixes too (such as making markDirty much faster, for example). See the following profile: https://spark.lucko.me/a8RSuQFJLl. Please let me know if you have any questions.

commented

Thanks for the report. I use a loader neutral inventory system in Bookshelf for this mod so I will have to look into how I can support Fabric's custom stuff. Currently focusing on 1.20 and 1.20.1 right now though.