Bountiful (Fabric)

Bountiful (Fabric)

7M Downloads

Some Bounties cause crashes

adiminut-givex opened this issue ยท 6 comments

commented

SORRY, here's the proper format thanks!

Observed Behaviour
What happened:
I finished this bounty and went to cash in for my reward and got a crash. I tried again, got another crash. The items however do drop, but the crash seems to happen just after they drop. I am with 64 other mods, all which are very minor.
image

Crash Log:
crash-2020-03-23_22.40.28-server.txt

Expected Behaviour
Should have provided me the banner rewards

Fore Version: forge-1.15.2-31.1.27
Bountiful Verison: Morpheus-1.15.2-4.2.50
Other Mods:

mods.zip

Steps to reproduce
Finish above bounty and try to get the reward

commented

Please conform to the GitHub issue template so that I have all the information necessary to see what's causing the crash. I need a crash log, plus all version numbers (Forge, in this case)

commented

Got the info - I'll look into this! It looks like a problem with Item-Tag objectives (e.g. Random Banners) that reward a random item from a tag list. Most of these objectives come from the shepherding decree - so I suspect that's what you're using. For now, avoid bounties that ask for / reward "Any ___" or "Random ___" (Other decrees usually don't have these).

Thanks, appreciate the fast response, really awesome!

commented

Got the info - I'll look into this! It looks like a problem with Item-Tag objectives (e.g. Random Banners) that reward a random item from a tag list. Most of these objectives come from the shepherding decree - so I suspect that's what you're using. For now, avoid bounties that ask for / reward "Any ___" or "Random ___" (Other decrees usually don't have these).

commented

Got the info - I'll look into this! It looks like a problem with Item-Tag objectives (e.g. Random Banners) that reward a random item from a tag list. Most of these objectives come from the shepherding decree - so I suspect that's what you're using. For now, avoid bounties that ask for / reward "Any ___" or "Random ___" (Other decrees usually don't have these).

It isn't an official modpack, just some mods I threw together to play with my friends. As for the decree I'm not sure about the name, but there was only 1 decree in the bounty board, and it allowed the banner bounties to spawn. As far as I'm aware there are no custom bounties.

commented

I've figured out the problem - I was using a clientside method getDefaultInstance which does not exist on the server. I will switch it to creating a wholly new itemstack. This will be fixed has been fixed with v3.1.0 and be out quite soon - all I've got left for v3.1.0 is some testing.

commented

I've figured out the problem - I was using a clientside method getDefaultInstance which does not exist on the server. I will switch it to creating a wholly new itemstack. This will be fixed has been fixed with v3.1.0 and be out quite soon - all I've got left for v3.1.0 is some testing.

Cheers, appreciate your hard work to get this fixed. We are still thoroughly enjoying your mod and look forward to the updates.