Brandon's Core

Brandon's Core

Mods
78M Downloads

When using this as a dependency, recompiling fails

BrainStone opened this issue ยท 1 comments

commented

When I try to run setupDecompWorkspace with the most recent version of this, it runs fine until it hits recompileMC. Then it errors with Compile failed; see the compiler error output for details.. Running it again with the --info flag yields the following:

Error:

[ant:javac] C:\Users\Yannick\Modding\BrainStoneMod\build\tmp\recompileMc\sources\net\minecraftforge\client\model\SimpleModelFontRenderer.java:64: error: renderDefaultChar(int,boolean) in SimpleModelFontRenderer cannot override renderDefaultChar(int,boolean) in FontRenderer
[ant:javac]     protected float renderDefaultChar(int pos, boolean italic)
[ant:javac]                     ^
[ant:javac]   attempting to assign weaker access privileges; was public
[ant:javac] C:\Users\Yannick\Modding\BrainStoneMod\build\tmp\recompileMc\sources\net\minecraftforge\client\model\SimpleModelFontRenderer.java:159: error: renderUnicodeChar(char,boolean) in SimpleModelFontRenderer cannot override renderUnicodeChar(char,boolean) in FontRenderer
[ant:javac]     protected abstract float renderUnicodeChar(char c, boolean italic);
[ant:javac]                              ^
[ant:javac]   attempting to assign weaker access privileges; was public
[ant:javac] C:\Users\Yannick\Modding\BrainStoneMod\build\tmp\recompileMc\sources\net\minecraftforge\client\model\FancyMissingModel.java:60: error: renderUnicodeChar(char,boolean) in <anonymous net.minecraftforge.client.model.FancyMissingModel$1$1> cannot override renderUnicodeChar(char,boolean) in FontRenderer
[ant:javac]                 protected float renderUnicodeChar(char c, boolean italic)
[ant:javac]                                 ^
[ant:javac]   attempting to assign weaker access privileges; was public

I'm guessing that incompatibility arises because in recent versions of Forge they changed the corresponding methods in their code. I am using Forge 1.12.2 - 14.23.3.2655 btw

Full log: https://gist.github.com/BrainStone/21633afc5add2e2cab7a8b45b6dd62d0
Repo: https://github.com/BrainStone/brainstone

commented

This commit introduces the issue! 58e198d

So changing the line public net.minecraft.client.gui.FontRenderer *() to protected net.minecraft.client.gui.FontRenderer *() seems to still compile and would fix it.