Better Recipe Books (+ Smithing Tables, Brewing Stands)

Better Recipe Books (+ Smithing Tables, Brewing Stands)

423k Downloads

[Bug]: Crash with pinned recipes when using Deeper and Darker

Proxi2 opened this issue · 0 comments

commented

What happened?

When used with the Deeper and Darker mod, and with a recipe pinned (any recipe), if you open the smithing table, you get kicked out of the world and get this message:
image

To reproduce, add Deeper and Darker and Better Recipe Book to you the modslist, open up a world, pin any recipe in the crafting table, and open up a smithing table. You'll instantly get kicked out.

This honestly took forever to find because I use a giant modpack, so it was hard to narrow down, but I really like BRB, so I'm hoping you could help me out with a fix/workaround. If you need any other information I'm happy to help

Modloader

Fabric (Default)

Minecraft Version

1.21

Mod Version

[Fabric] 1.10.0-rc5+1.21

Relevant log output

---- Minecraft Network Protocol Error Report ----
// Abort, Retry, Ignore?

Time: 2024-10-18 18:59:15
Description: Packet handling error

java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
	at knot//marsh.town.brb.recipe.BRBSmithingRecipe.id(BRBSmithingRecipe.java:65)
	at knot//marsh.town.brb.generic.GenericRecipeBookCollection.has(GenericRecipeBookCollection.java:32)
	at knot//marsh.town.brb.PinnedRecipeManager.has(PinnedRecipeManager.java:102)
	at knot//marsh.town.brb.interfaces.IPinningComponent.betterRecipeBook$sortByPinsInPlace(IPinningComponent.java:15)
	at knot//marsh.town.brb.generic.GenericRecipeBookComponent.updateCollections(GenericRecipeBookComponent.java:265)
	at knot//marsh.town.brb.generic.GenericRecipeBookComponent.initVisuals(GenericRecipeBookComponent.java:140)
	at knot//marsh.town.brb.smithingtable.SmithingRecipeBookComponent.init(SmithingRecipeBookComponent.java:39)
	at knot//net.minecraft.class_4895.handler$zdi001$brb$init(class_4895.java:546)
	at knot//net.minecraft.class_4895.method_25445(class_4895.java:72)
	at knot//net.minecraft.class_4894.method_25426(class_4894.java:26)
	at knot//net.minecraft.class_437.method_25423(class_437.java:309)
	at knot//net.minecraft.class_310.method_1507(class_310.java:1143)
	at knot//net.minecraft.class_3929$class_3930.method_17543(class_3929.java:61)
	at knot//net.minecraft.class_3929.method_17541(class_3929.java:47)
	at knot//net.minecraft.class_634.method_17587(class_634.java:1226)
	at knot//net.minecraft.class_3944.method_17591(class_3944.java:38)
	at knot//net.minecraft.class_3944.method_11054(class_3944.java:13)
	at knot//net.minecraft.class_2600.method_11072(class_2600.java:27)
	at knot//net.minecraft.class_1255.method_18859(class_1255.java:162)
	at knot//net.minecraft.class_4093.method_18859(class_4093.java:23)
	at knot//net.minecraft.class_1255.method_16075(class_1255.java:136)
	at knot//net.minecraft.class_1255.method_5383(class_1255.java:121)
	at knot//net.minecraft.class_310.method_1523(class_310.java:1240)
	at knot//net.minecraft.class_310.method_1514(class_310.java:882)
	at knot//net.minecraft.client.main.Main.main(Main.java:256)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
	at knot//marsh.town.brb.recipe.BRBSmithingRecipe.id(BRBSmithingRecipe.java:65)
	at knot//marsh.town.brb.generic.GenericRecipeBookCollection.has(GenericRecipeBookCollection.java:32)
	at knot//marsh.town.brb.PinnedRecipeManager.has(PinnedRecipeManager.java:102)
	at knot//marsh.town.brb.interfaces.IPinningComponent.betterRecipeBook$sortByPinsInPlace(IPinningComponent.java:15)
	at knot//marsh.town.brb.generic.GenericRecipeBookComponent.updateCollections(GenericRecipeBookComponent.java:265)
	at knot//marsh.town.brb.generic.GenericRecipeBookComponent.initVisuals(GenericRecipeBookComponent.java:140)
	at knot//marsh.town.brb.smithingtable.SmithingRecipeBookComponent.init(SmithingRecipeBookComponent.java:39)
	at knot//net.minecraft.class_4895.handler$zdi001$brb$init(class_4895.java:546)
	at knot//net.minecraft.class_4895.method_25445(class_4895.java:72)
	at knot//net.minecraft.class_4894.method_25426(class_4894.java:26)
	at knot//net.minecraft.class_437.method_25423(class_437.java:309)
	at knot//net.minecraft.class_310.method_1507(class_310.java:1143)
	at knot//net.minecraft.class_3929$class_3930.method_17543(class_3929.java:61)
	at knot//net.minecraft.class_3929.method_17541(class_3929.java:47)

-- Incoming Packet --
Details:
	Type: clientbound/minecraft:open_screen
	Is Terminal: false
	Is Skippable: false
Stacktrace:
	at knot//net.minecraft.class_2600.method_59803(class_2600.java:56)
	at knot//net.minecraft.class_8673.method_60882(class_8673.java:136)
	at knot//net.minecraft.class_8673.method_59807(class_8673.java:113)
	at knot//net.minecraft.class_2600.method_11072(class_2600.java:32)
	at knot//net.minecraft.class_1255.method_18859(class_1255.java:162)
	at knot//net.minecraft.class_4093.method_18859(class_4093.java:23)
	at knot//net.minecraft.class_1255.method_16075(class_1255.java:136)
	at knot//net.minecraft.class_1255.method_5383(class_1255.java:121)
	at knot//net.minecraft.class_310.method_1523(class_310.java:1240)
	at knot//net.minecraft.class_310.method_1514(class_310.java:882)
	at knot//net.minecraft.client.main.Main.main(Main.java:256)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

-- Connection --
Details:
	Protocol: play
	Flow: CLIENTBOUND
	Server type: <none>
	Server brand: fabric

-- System Details --
Details:
	Minecraft Version: 1.21
	Minecraft Version ID: 1.21
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 21.0.4, Azul Systems, Inc.
	Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Azul Systems, Inc.
	Memory: 530242992 bytes (505 MiB) / 1696595968 bytes (1618 MiB) up to 4294967296 bytes (4096 MiB)
	CPUs: 20
	Processor Vendor: GenuineIntel
	Processor Name: 13th Gen Intel(R) Core(TM) i5-13600K
	Identifier: Intel64 Family 6 Model 183 Stepping 1
	Microarchitecture: Raptor Lake
	Frequency (GHz): 3.49
	Number of physical packages: 1
	Number of physical CPUs: 14
	Number of logical CPUs: 20
	Graphics card #0 name: NVIDIA GeForce RTX 2070 SUPER
	Graphics card #0 vendor: NVIDIA
	Graphics card #0 VRAM (MiB): 8192.00
	Graphics card #0 deviceId: VideoController1
	Graphics card #0 versionInfo: 32.0.15.6590
	Graphics card #1 name: Intel(R) UHD Graphics 770
	Graphics card #1 vendor: Intel Corporation
	Graphics card #1 VRAM (MiB): 1024.00
	Graphics card #1 deviceId: VideoController2
	Graphics card #1 versionInfo: 31.0.101.4577
	Memory slot #0 capacity (MiB): 16384.00
	Memory slot #0 clockSpeed (GHz): 6.00
	Memory slot #0 type: Unknown
	Memory slot #1 capacity (MiB): 16384.00
	Memory slot #1 clockSpeed (GHz): 6.00
	Memory slot #1 type: Unknown
	Virtual memory max (MiB): 36615.84
	Virtual memory used (MiB): 17016.75
	Swap memory total (MiB): 4096.00
	Swap memory used (MiB): 76.96
	Space in storage for jna.tmpdir (MiB): available: 105344.32, total: 953352.69
	Space in storage for org.lwjgl.system.SharedLibraryExtractPath (MiB): available: 105344.32, total: 953352.69
	Space in storage for io.netty.native.workdir (MiB): available: 105344.32, total: 953352.69
	Space in storage for java.io.tmpdir (MiB): available: 105344.32, total: 953352.69
	Space in storage for workdir (MiB): available: 105344.32, total: 953352.69
	JVM Flags: 2 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx4096M
	Fabric Mods: 
		architectury: Architectury 13.0.8
		brb: Better Recipe Book 1.10.0-rc5+1.21
			cloth-config: Cloth Config v15 15.0.127
				cloth-basic-math: cloth-basic-math 0.6.1
		deeperdarker: Deeper and Darker 1.3.2.1
			customportalapi: Custom Portal Api 0.0.1-beta66-1.21
		fabric-api: Fabric API 0.102.0+1.21
			fabric-api-base: Fabric API Base 0.4.42+6573ed8cd1
			fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.68+b5597344d1
			fabric-biome-api-v1: Fabric Biome API (v1) 13.0.29+5bd9f1bcd1
			fabric-block-api-v1: Fabric Block API (v1) 1.0.22+0af3f5a7d1
			fabric-block-view-api-v2: Fabric BlockView API (v2) 1.0.10+6573ed8cd1
			fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.52+0af3f5a7d1
			fabric-client-tags-api-v1: Fabric Client Tags 1.1.15+6573ed8cd1
			fabric-command-api-v1: Fabric Command API (v1) 1.2.49+f71b366fd1
			fabric-command-api-v2: Fabric Command API (v2) 2.2.28+6ced4dd9d1
			fabric-commands-v0: Fabric Commands (v0) 0.2.66+df3654b3d1
			fabric-content-registries-v0: Fabric Content Registries (v0) 8.0.16+b5597344d1
			fabric-convention-tags-v1: Fabric Convention Tags 2.0.19+7f945d5bd1
			fabric-convention-tags-v2: Fabric Convention Tags (v2) 2.5.0+c5e2b5c6d1
			fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.29+0af3f5a7d1
			fabric-data-attachment-api-v1: Fabric Data Attachment API (v1) 1.1.27+6a6dfa19d1
			fabric-data-generation-api-v1: Fabric Data Generation API (v1) 20.2.16+16c4ae25d1
			fabric-dimensions-v1: Fabric Dimensions API (v1) 4.0.0+6fc22b99d1
			fabric-entity-events-v1: Fabric Entity Events (v1) 1.6.12+6fc22b99d1
			fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.7.12+ba9dae06d1
			fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.53+6ced4dd9d1
			fabric-item-api-v1: Fabric Item API (v1) 11.0.0+afdfc921d1
			fabric-item-group-api-v1: Fabric Item Group API (v1) 4.1.4+78017270d1
			fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.47+0af3f5a7d1
			fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.45+df3654b3d1
			fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.3.12+6c1df360d1
			fabric-loot-api-v2: Fabric Loot API (v2) 3.0.14+3f89f5a5d1
			fabric-loot-api-v3: Fabric Loot API (v3) 1.0.2+3f89f5a5d1
			fabric-message-api-v1: Fabric Message API (v1) 6.0.13+6573ed8cd1
			fabric-model-loading-api-v1: Fabric Model Loading API (v1) 2.0.0+fe474d6bd1
			fabric-networking-api-v1: Fabric Networking API (v1) 4.2.2+60c3209bd1
			fabric-object-builder-api-v1: Fabric Object Builder API (v1) 15.2.0+a551f7a4d1
			fabric-particles-v1: Fabric Particles (v1) 4.0.2+6573ed8cd1
			fabric-recipe-api-v1: Fabric Recipe API (v1) 5.0.12+65089712d1
			fabric-registry-sync-v0: Fabric Registry Sync (v0) 5.1.2+60c3209bd1
			fabric-renderer-api-v1: Fabric Renderer API (v1) 3.4.0+c705a49cd1
			fabric-renderer-indigo: Fabric Renderer - Indigo 1.7.0+c705a49cd1
			fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.68+df3654b3d1
			fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.48+73761d2ed1
			fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.1.6+b5597344d1
			fabric-rendering-v0: Fabric Rendering (v0) 1.1.71+df3654b3d1
			fabric-rendering-v1: Fabric Rendering (v1) 5.0.5+df16efd0d1
			fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 4.3.0+8dc279b1d1
			fabric-resource-loader-v0: Fabric Resource Loader (v0) 1.3.0+56599129d1
			fabric-screen-api-v1: Fabric Screen API (v1) 2.0.24+b5597344d1
			fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.3.86+b5597344d1
			fabric-sound-api-v1: Fabric Sound API (v1) 1.0.23+6573ed8cd1
			fabric-transfer-api-v1: Fabric Transfer API (v1) 5.1.16+3dccd343d1
			fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 6.1.0+176f9036d1
		fabricloader: Fabric Loader 0.16.7
			mixinextras: MixinExtras 0.4.1
		java: OpenJDK 64-Bit Server VM 21
		minecraft: Minecraft 1.21
		owo: oωo 0.12.15+1.21
			blue_endless_jankson: jankson 1.2.2
			io_wispforest_endec: endec 0.1.5
			io_wispforest_endec_gson: gson 0.1.3
			io_wispforest_endec_jankson: jankson 0.1.3
			io_wispforest_endec_netty: netty 0.1.2