Better Recipe Books (+ Smithing Tables, Brewing Stands)

Better Recipe Books (+ Smithing Tables, Brewing Stands)

751k Downloads

Client Lags when using crafting table with datapacks that add custom recipes

BreadMoirai opened this issue ยท 7 comments

commented

Client Lags when using crafting table

This occurs when the server has datapacks installed that add custom recipes to the crafting table.
See example Stardew Valley Datapack

Reproduce

Install datapack Stardew Valley Datapack
Open Crafting Table

Environment

Minecraft 1.18.2
BRB Fabric 1.5.6

Graphics Card: Radeon RX 580x
RAM allocated: 8 GB
Processor: i5-6600K

commented

thank you for the amazing issue, ill look into it. Potion loading is terrible but crafting table shoulnt be too bad..

commented

Hello. I have never used datapacks before, so it took me a bit to get to this.

Unfortunately the mod does lag when you use a datapack, because there is no way for the mod to "pre-load" the recipes as it has no way for it to know when the datapack will be enabled-disabled or what datapacks even exist. It only lags once and i think its okay to live with. Its not meant to be competitive with JEI and using it with other mods is just a bonus.

However using the stardew pack it does fill the book full of knowledge books, i dont know if thats a stardew thing or if its a mod bug thing

commented

Understandable. I guess I must have not waited long enough for it to stop lagging lol.
Stardew datapack custom recipes will output a knowledge book and then detects that with a recipe unlocked advancement and replaces that knowledge book with the correct item since there's no way to use custom nbt in the vanilla crafting table.

The knowledge books do not show up in the vanilla crafting book. You may just have all recipes unlocked option turned on since those recipes should always be locked

commented

on my computer it only lags for a second. How long does yours? A more appropriate word would be hang

commented

My Minecraft application will hang for about 20 seconds.

commented

Every time?

commented

Will hang every time I open a world and then a crafting table.