Brutal Bosses - Custom Bosses[Forge/Fabric]

Brutal Bosses - Custom Bosses[Forge/Fabric]

12M Downloads

[Bug]: GoalSelector.removeGoal() taking very long to execute with BrutalBosses

Closed this issue ยท 3 comments

commented

Describe the bug you're experiencing

I have playtested a modpack i am working on yetserday and after a few hours of gameplay we noticed how suddenly the tps dropped.

Looking at F3+2 the mspt showed that frequent ticks took over 70ms to complete. While investigating, this number rised to over 100ms (it increased slowly further and further, this can also be seen in the log below [01Jun2025 21:02:17.964]).

Ive immediatly started a spark profiler capturing everything above 50ms and it showed the brutalbosses mod taking a very long time to execute
Image

Here is a copy of the spark profile that can be uploaded to https://spark.lucko.me/ for inspection
UR5wIuLood.zip

This issue might be related to #84 (cant quite tell the information they give is not enough)

In this modpack we use 2 more mods that alter the outfits of mobs.

Minecraft Version: 1.21.1
Modloader: NeoForge 21.1.168
BrutalBosses. 1.21-8.1

Very happy to help if possible.

Reproducability

Unknown unfortunately. It happend out of nowhere

Mod up to date

  • Before submitting this issue I updated to the newest version and reproduced it

Minecraft version

1.21.1

Modloader version

NeoForge 21.1.168

Logs and Datapacks

https://pastebin.com/raw/YxGfPYBP

commented

That call can only be slow when there is hundreds or even thousands of goals in that list, since the reequip is called occasionally you most likely have one mod in your pack which adds new ai goals on equipment change for those entities. (Or some performance mod is messing up the goal selector)
I can debug it if you send me the full pack used

commented

I pushed an update which slows the rate at which the gear gets reset considerably, this will not solve this issue but does slow down the time until it piles up too much.

Closing since its caused by unknown other mods adding additional AI goals

commented

Thank you for looking into it! I will try to see what could be causing this.