How to add slot in game?
ukmojb opened this issue · 6 comments
Change the slots.json file in the baubles directory that's inside config
Sorry, what I meant was to add slots to individual players in the running game like the Curios API /curios add directive
https://github.com/ukmojb/Bubbles-ex
I opened a new branch of my own to implement this function.
And do you read Chinese?))))))
I did some research on why the baubles didn't work, but my English was poor and I had to use a translator.
This feature takes long to implement because I don't mod quite much and it takes long to implement because of me wanting this mod to be able to get used as an actual API. If what you need is a basic command implementation you can just fork it and it looks like you already did. Also no, I don't understand Chinese.
The reason why some baubles don't work might be because the mod it's from hardcodes the slot index. Nearly all of the Vazkii's mods are great examples for it and I hate their baubles implementation because of that. I'd appreciate if you get me up to speed with mods or specific baubles that don't work well with "custom slots" feature.
In your fix for the Travel Belt, you directly used BaublesApi.isBaubleEquipped to check whether it is equipped. However, both Globetrotter's Sash and Planestrider's Sash inherit their logic from Soujourner's Sash, so their checks also end up calling BaublesApi.isBaubleEquipped(player, Soujourner's Sash), which causes them to fail detection.
Here is my implementation—you can take a look. (But I don’t know how to modify bytecode, so I used Mixin instead.)
https://github.com/ukmojb/Bubbles-ex/blob/master/src/main/java/baubles/mixins/botania/MixinTravelBelt.java