BucketLib

BucketLib

6M Downloads

[Bug]: liquid dyes added by Create Dragons Plus render as white

TheJacksonOfGreen opened this issue ยท 2 comments

commented

Minecraft Version

1.21.1

Mod Loader

NeoForge

Mod Loader Version

21.1.174

Mod Version

BucketLib 1.21-4.1.4.0

Modpack or other Mod

Ceramic Bucket 1.21-6.1.1.0
Create 6.0.4
Create: Dragons Plus 1.5.2

Describe the Issue

The Liquid Dyes added by Create Dragons Plus render as white in BucketLib Buckets no matter what color they actually are. This was the developer of Dragons Plus' explanation:

Image

Logs

N/A

Do you use any performance-enhancing mods (e.g. OptiFine)?

Embeddium 1.0.15

commented

thanks for your report! I will look into that when I have time :)

commented

The tint of the fluids were already used. But there is also a method "getTintColor" without parameters which defaults to -1 when not overwritten (like Create Dragons Plus) which was used by BucketLib. This method is marked as "default accessor" and was interpreted as the correct method for this. But there are also methods marked as "Stack-Based Accessor" and "Level-Based Accessors" which are overwritten by Create Dragons Plus. So, now I decided to use the "Stack-Based Accessor" method and hope that other mods are also interpreting this like the developers from Create Dragons Plus and I. :)

fixed in

  • 1.21-4.1.4.1
  • 1.21.3-4.2.2.1

Thanks again for your report!