BuildCraft|Builders

BuildCraft|Builders

6M Downloads

Crash with tetra when loading

AlexIIL opened this issue ยท 3 comments

commented

Original report: https://minecraft.curseforge.com/projects/buildcraft?gameCategorySlug=mc-mods&projectID=61811#c791
Crash: https://pastebin.com/raw/HJkjvd0J

Unlike all of the other silicon facade crashes this one's probably our fault, as we query data from an item before init() has finished (and tetra uses that for setup). So I don't think we can just blame them for not doing null-checks.

commented

I think the crash is caused by BlockGeode.variants being null when bc silicon calls damage dropped, I don't think the state parameter is null. So you could technically fix it from your side by checking to see if this.variants is null but I think that's kinda hacky :(

Sorry for not reporting this to you originally but I think it's best fixed on BuildCraft's side?

commented

Are there other cases where the the blockstate parameter in Block.damageDropped is nullable? If so I should probably fix it on my side!

commented

Apologies for the slow response.

You're right! I'll try to make it a bit more robust in tetra, but I guess buildcraft could benefit from having some form of safeguard when initializing the facades.

I'll try to refer to this issue when I "fix" it in tetra, and then you can decide if you want to fix it in BC as well or if you'd like to close this!