Add a Config Option to Disable Update Check.
StoneLegion opened this issue · 17 comments
Could you add a config option to disable update checks, please and thank you :)
I don't want to be a pain, but buildcraft's update check crashes my server very frequently. It also makes my server take forever to load, and keeps retrying over and over.
Im sure we can tie my issues to my "underpowered" server hardware but according to the server logs the only issue is with the update requests.
I Did find this
But I can't find the common/buildcraft/BuildCraftCore.java to edit.
Any help/suggestions or implementation of a config option is greatly appreciated.
If you want any further info on my underpowered server to help isolate why its so problimatic for me, just ask.
1GHZ single core 512 Ram Linux Core 1gb ramdrive.
Yes I run my personal server on an old E-PC, runs fine with all the other mods I use, And only has issues from what I see, when BuildCraft checks for updates. Though I have turned other mods update checks off.
EDIT:
2013-09-23 04:17:05 [WARNING] [Minecraft-Server] To change this, set "online-mod
e" to "true" in the server.properties file.
2013-09-23 04:20:04 [WARNING] [Buildcraft] Unable to read from remote version au
thority.
2013-09-23 04:20:04 [WARNING] [Buildcraft] java.net.ConnectException: Connection
timed out: connect
2013-09-23 04:20:04 [INFO] [Buildcraft] Version check attempt 1 failed, trying a
gain in 10 seconds
Added that to show the 3 minute gap in time, this 3 minute gap shuts down the server randomly always resulting in.
[WARNING] [Buildcraft] Unable to read from remote version au
thority.
[WARNING] [Buildcraft] java.net.ConnectException: Connection
timed out: connect
[INFO] [Buildcraft] Version check attempt 1 failed, trying a
gain in 10 seconds
After which I can play again for a while before it checks again.
At the end of the day if its possible to disable it then boot time 'is' quicker and log files are that tiny bit smaller.
Beyond that isn't it standard practice to make such thing configurable?
So either way I'm looking forward to how this is resolved and hopefully we can have our 'toggle off'.
"Flow86 closed the issue in #1231 16 hours ago"
Im sorry, Im new to these forums and how this stuff works, what does that mean?
"Prototik"
https://github.com/Prototik/BuildCraft/commit/83298c9b944f4e4b3e323340119dc7a718c204d8
That looks like exactly what im after, so how do I make that work in my minecraft install?
"Finalsilver"
"Beyond that isn't it standard practice to make such thing configurable?"
Every other addon I have has this option, If I had good network connection I might leave it on, but most websites seem to have connection issues for me, hence massive load time increases.
Apart from that its an epic mod, And since I can bypass the update check in single player using a bat loader its EPIC, but I do like to play with my wife and kid, and thats were my issue arises.
Thanks for the replys.
Flow86 merged commit a52437b into BuildCraft:master from Prototik:master 16 hours ago
That means that the change you see has been included into buildcraft. It will be insid the next release or you compile bc yourself. You can also look for a ci that builds buildcraft for you.
Legendary, much appreciation to all, looking forward to faster load times and less hang ups.
@Spikefin77 Buildcraft uses a threaded version check, its incapable of causing slow loading or hang ups.
The main thread will continue to do what it does while the version check thread spends the majority of the time waiting in sleep mode for the network to respond. In fact its probably not even on the same processor core.
This thing again?
Since the update check is threaded, you won't see any improvement whatsoever in loading times by disabling the BC update check. If you do it is a placebo effect, or a very unlikely flaw in the threading.
But I'll buy the argument that having it disabled in a server's distributed configuration leads to fewer user errors when users update their BC version ahead of the server.
@Spikefin77 what OS do you have and what version of Java are you using?
My guess is that your pc hangs completely while java is trying to connect. There should be a reasonable timeout set on the HttpURLConnection instead of waiting forever.
CovertJaguar
I did stipulate my low spec PC in the OP, It would be hard to use a separate core on a single core processor.
psxlover
Windows XP, and you know what, the version of Java will be well out of date. Ill check into that immediatly, sorry about the delay in responding, as previously stated, The internet here is not so reliable, And I couldn't get on.
Also, Will add, disabling Build craft results in the server not hanging. Obviously this is not an Ideal solution, But thanks for all the feedback.
Also, Though I don't program Java, In my outdated programing (In another language) experience. Threading has better software implementation than hardware allows in my programming environment, due to the inability for binary systems to ever do more things than 1 at a time. Only allowing a cycle split giving an appearance of dis-association with "Main Threads" while still following the basic cpu cycling were tied to with electrical computing.
So though in ideal environments, with high cycle turnover, the multi threading may well appear to totally remove one threads delay from another visible thread, In non ideal environments, such as my poor setup, with low spec hardware, The chance of me noticing the "cycle crossover" is much higher,
Though I don't expect you to pander to every configuration ofc, And I greatly appreciate everyone who puts in there time to make this game so great, Just felt the need to insert that bit as so many people keep throwing out the threading argument in so many threads, totally ignoring real hardware restrictions.
Keep up the good work, and I can't check my Java atm, no net connection available to java site.
There is apsolutely no need to disable update checks! They run in the
background, in a separate thread, and you don't need to worry about them at
all!
-------Original Message-------
From: Kane Hart
Date: 09/02/13 01:57:15
To: BuildCraft/BuildCraft
Subject: [BuildCraft] Add a Config Option to Disable Update Check. (#1183)
Could you add a config option to disable update checks, please and thank you
:)
—
Reply to this email directly or view it on GitHub.
Update check is threaded, which was the outcome of #597
It's your mod just one my personal requests. I myself don't like any update checks separate thread or not I just don't want the intrusion at all :)
But hey GregTech, BuildCraft I guess no one cares how intrusive they become muhaha :)
In case it's not obvious then being able to disable update checks is pretty good for servers that have players that might get confused about the message (read: noobs).