BuildCraft|Core

BuildCraft|Core

7M Downloads

Request: possible LB intergration

Tarig0 opened this issue ยท 17 comments

commented

The slimevoid team has found a way to allow for LB to handle containers within a LB chunk.

This is done by integrating with a Slimevoid helper class. The issue is that we need a mod to reference this helper to allow us to interact with the blocks in the Little chunk. Would you be able to do this?

I am willing to make a PR if this is not shot down and no one else creates the PR.

commented

Add this class into vanilla TE class. Problem solved.

commented

That would require a PR for forge wouldn't It? how can we do this with out a coremod?

commented

Mind explaining how this is related to BuildCraft?

commented

@Krapht

We need the TEs in buildcraft to detect if slimevoid lib is installed and then point a few of it's function to a helper class so we can interact with and access the tileentity in the LB chunk from the overworld

just because laz says we can do this without chaning buildcraft doesn't mean we can.. at least not without chaning core files and we don't like doing that

commented

So because you dont like to make a coremod you want every single mod you can think of to implement this?

commented

.... It's a request if I can do it without a coremod that would be best. Other mods get cross mod compatibility why do I get the instant shaft.

Plus the mods could override the vannila class functions we over write and that would break the compatibility. I can and don't mind doing the core mod but it's a last resort

commented

The whole premise of a Coremod goes against Development best practices and is in essence a live 'hack'. Core mods should not be undertaken lightly or created without a fundamental requirement. If there is a legitimate way of implementing cross mod compatibility then we should follow that route and avoid the Coremod principle where possible.

Tarig has only requested that BC implement a technique for handling tile entities in order to make Buildcraft Compatible with Littleblocks, much in the way IC and BC work together.

If abstraction is done correctly for BCs tile entity handling it should be no more than a facade class to pass the check/retrieval to the SlimevoidHelper if it is installed.

There's no need to flame and point to core mods as a scape goat as that is (in my opinion) a defeatist approach and goes against a collaborative community.

commented

I'll sum this up in a few words, "what the hell is LB?"

commented

Greg, mod dev for MC is IMPOSSIBLE without hacks. Forge is one big hack,
too. Deal with it.

commented

@jk-5 Thanks! I'll have Tarig take a look at it and we'll most likely be in-touch!

I'm still a firm believer that CoreMods are not the answer though! ;)

commented

@jk-5 thanks for the offer of help. I'll put together the core mod as best as I can, before I look you up

commented

Laz, I find your statement amusing :)

Either way, if there's a way to accomplish our goal without the need for additional hacks, we should focus on that, and not shy away from it.

Out of curiosity, how many of those who shout and point to --->>> 'Coremods' have successfully implemented one (that does something more than simply changing spawnEntity=true), and have it open source for all to browse?

commented

@CovertJaguar @leftyde is correct. LB = LittleBlocks. @leftyde Thanks for the link ;)

commented

@Eurymachus i point to 'Coremods', and i have succesfully implemented a coremod that does change more than just a boolean or a random method call somewhere. If you have a little knowledge about how java works internally and are smart enough to see how the bytecode works(which is not too difficult), making a coremod is easy.
I think it would be a cleaner way (and a more compatible way) for you to implement it as a coremod instead of asking some mods to change things on their end. Just try it, it's not that difficult

commented

@jk-5 I was just nosing at your NexusClient. Is this the successfully implemented coremod, or is it one of your other repos?

commented

@Eurymachus Well, yeah. That one is my coremod test project (i know it's against the rules, but i did it so i can figure out how it works). That one just works and does its job nicely. If you have questions about that repository or about the coremod thing you can always ask me on irc.

Edit:
https://github.com/jk-5/NexusClient-Java is the working version of that one