BuildCraft|Core

BuildCraft|Core

7M Downloads

IFluidContainer Support

Soaryn opened this issue ยท 6 comments

commented

Current FluidContainerRegistry, does not allow for a dynamic fluid list to be generated without some issues to the meta list to occur. FluidContainerRegistry only allows for id and meta, NBT is needed for smooth addition/removal of fluids to the list.

IFluidContainers allow for a bucket, can, what have you to be filled with anything if done appropriately.
2013-11-23_16 34 26

However, buildcraft doesnt seem to utilize the IFluidContainer at all for things such as filling a tank, choosing a refinery filter, etc.

commented

Realistically only inventories should consider the IFluidContainers, as for basic tanks, the RClicking can be done on my side

commented

I don't even know what you are asking, but I think its a duplicate of #1157

And since Forge still hasn't implemented a unified container bridge utility class (I even submitted one), the requirements for further development have not been met.
MinecraftForge/MinecraftForge#813

commented

Well for the refinery, choosing the filter fluid is done through Containers; however, IFluidcontainers are neither drained nor filled in this instance, a getFluid would suffice.

commented

Make a PR (one that isn't broken this time -.-)

commented

Nah I'm good. I already did that once before, was criticized all the way through. You can do it. ๐Ÿ˜
Also, that utility class isn't being accepted as the Fluid API is getting another rewrite iirc.

commented

Ok, closing then. Since I still have no idea what you want.