Gate triggers don't work as expected with double chests

Question

Gate triggers don't work as expected with double chests

buttilda opened this issue 11 years ago · 17 comments

buttilda commented 11 years ago

Pipes work just fine, but triggers don't.

For example:
The trigger "Inventory is Empty" might be active even though the double chest contain items. That could happen if the items where in the "side" that the gate isn't touching.

Okay, I fail to explain myself... I hope that made any sense whatsoever.

PS.: I know CJ is rewriting the gates so I don't know if this is happening because they are still a work in progress.
PPS.: Gates are also reseting after you log out and back in. My autarchic gate turned into a normal gate, and the triggers set in it were lost. Again, I know they are in the process of being re-written so this might be a known issue.

SpaceToad · Answer 1 · 2014-02-24T07:12:10.000Z

That has been fixed - closing.

AEnterprise · Answer 2 · 2013-12-11T16:21:09.000Z

what version of buildcraft and forge are you using?

buttilda · Answer 3 · 2013-12-11T16:27:28.000Z

@AEnterprise It's on my dev environment with forge 953 and the the updated source from BC

AEnterprise · Answer 4 · 2013-12-11T16:30:56.000Z

source, so you downloaded it here or from the official site? cause the version on the official site if from before the start of the gate rewrite

buttilda · Answer 5 · 2013-12-11T16:34:17.000Z

@AEnterprise I forked it from this repo...

Speiger · Answer 6 · 2013-12-11T16:34:13.000Z

Ok that explained my question. I have the newest version of BC (not source) and i did not have any of these bugs xD

CovertJaguar · Answer 7 · 2013-12-11T20:31:35.000Z

Branch "marmot"?

buttilda · Answer 8 · 2013-12-11T20:35:13.000Z

@CovertJaguar yup. That's the one I was testing with because it's the one with the latest commits.

buttilda · Answer 9 · 2013-12-12T11:28:29.000Z

@AEnterprise How's that going to solve the problem....?
I'm not trying to play with a in-dev version (I'm smart like that). I'm just reporting what I think is a potential bug...

AEnterprise · Answer 10 · 2013-12-12T10:05:28.000Z

and that is the one with the gate rewrite, try reverting those commits

SandGrainOne · Answer 11 · 2013-12-12T11:40:24.000Z

I think CJ understood that so don't worry.

AEnterprise · Answer 12 · 2013-12-12T18:05:43.000Z

cause gates are undergoing a rewrite, i'm not sure about the exact stuff cause i'm not working on it but that might be what is causing the problem cause it worked in the past

buttilda · Answer 13 · 2013-12-12T18:08:21.000Z

Yes I know that.
I said it on the first post.

And I didn't ask for a solution, I was just reporting what I thought was an overlooked bug :)

CovertJaguar · Answer 14 · 2013-12-14T10:34:28.000Z

The only possible bug, is the double chest thing, not sure what's up with that, the rest is just unfinished.

buttilda · Answer 15 · 2013-12-23T19:34:22.000Z

@CovertJaguar I think I found what could be the problem...
The InventoryIterator doesn't take double chests into consideration
There should be a check like this one:

public static Iterable getIterable(IInventory inv, ForgeDirection side) {
        if (inv instanceof ISidedInventory) {
            return new InventoryIteratorSided((ISidedInventory) inv, side);
        } else if(inv instanceof TileEntityChest) {
            TileEntityChest tileChest = (TileEntityChest) inv;
            return new InventoryIteratorSimple(Block.chest.getInventory(tileChest.worldObj, tileChest.xCoord, tileChest.yCoord, tileChest.zCoord));
        }
        return new InventoryIteratorSimple(inv);
    }
        return new InventoryIteratorSimple(inv);
    }

I believe that would fix it. If you like it I can make the PR myself.

buttilda · Answer 16 · 2013-12-24T02:53:06.000Z

@CovertJaguar Well it was a quick suggestion :3 But at least it will get fixed XD

CovertJaguar · Answer 17 · 2013-12-24T00:50:46.000Z

@ganymedes01 yes, but we have a simpler more efficient function in one of the Utils classes for this, I'll fix it =P

Share to