BuildCraft|Core

BuildCraft|Core

7M Downloads

Gates don't get "lit" anymore when activated

SpaceToad opened this issue ยท 5 comments

commented

Seen on marmot. Would possibly make sense to use a more distinctive color scheme, in particular now that the gates get installed with extensions.

commented

Was this before or after my fix?

commented

Surprisingly, after too. I'm doing some work in this area to complete #1390, will probably see there what the problem if there is one or if it's just a setup issue on my end.

commented

In PipeRendererTESR.pipeGateRender, I replaced:
if (pipe.pipe.gate.isGateActive())
by
if (pipe.renderState.isGateLit())

That did the trick. It makes sense with the limited understanding I'm re-acquiring - let me know if I got it wrong. Otherwise, I'll check that in.

commented

Pushed a fix based on the following analysis. There's still some more work on the texture though. Making the dark gate grey instead of dark red will probably help seeing the different, but even so, the redstone fader gets hidden when the gate is active. Is that intended? If not, we can move to a different color scheme, e.g. red=off, green=on

commented

Oh, yes that should do it.

Meh, not a big deal about the fader.