BuildCraft|Core

BuildCraft|Core

7M Downloads

Custom Pipe API Pull Request

Speiger opened this issue ยท 6 comments

commented

After I requesting a PowerPipeAPI, which allow people to build their own custom power pipes without powerloss when they connecting to it. Spacetoad send me to the BC wiki. But instead of waiting for that the BC Team implement it, i write it by myself.

After a quite time thinking and testing i found a way how to do it.
Now sadly my Github Programm does no longer sync for me. So i have to give you a download link.
All Changes are Marked (if it is a overriding of a class)
Here is the downloadlink, its only a test how it could be looking. I still testing around to make it better but maybe you (BC Team) have a better idea how to solve it.

https://www.dropbox.com/s/g2p6ue2z9j662ky/BCCustomPipeUpdate.zip

Thankyou for reading, a short request to it if it gets implementet. Please also put it in a 1.6 update if you put it inside.

Anyway thanks again!

commented

Thanks for the path @Speiger - you got the right attitude :-)

It's going to be difficult to review a non-github-based patch though. Any chance that you fix your github environment?

commented

Not this and next week. I marked everything. So it shouldn't be to hard. Sorry SpaceToad. (Cool name by the way, it kinda remember me to mario xD). But if you want changes then make a quick backup from your bc code and add it to yours. If you are using the standart github then he should show you the changes without uploading.

commented

There's no rush ;-) There's significant amount of work happening on many fronts at the moment, and not being able to use the tools that are available to review and handle things really hinders efficiency. I'll close that for now, waiting for your pull request in a couple of weeks then ;-)

commented

Ok. I try to be fast but at the moment my Mod will be totally rewritten (and this part of the api would be totally required (because of the powerloss) thats why it will take some time^^"

commented

No problem. Thanks for helping BuildCraft to get better!