BuildCraft|Core

BuildCraft|Core

7M Downloads

Author info is missing

CovertJaguar opened this issue ยท 4 comments

commented

Information about who wrote a specific class (and who you should talk to if it breaks) has been stripped of the files. I am highly opposed to this development that should have been discussed with the rest of the team before being implemented.

commented

The problem with using a file header to determine ownership is...

  • It can change. Multiple authors can modify a single class, sure you can add both those names to the header, however, it will not help in tracking down who was responsible for the change
  • It has to be maintained. This isn't automatic. If I modify a class, I would then have to remember to place my name in the header. If I forget, it will likely never get caught, then the header is now invalid.

If you are simply concerned with keeping track of who owns which changes, then I think your problem is solved with github. You can very easily pull a history on a file and see everyone that changed it, and exactly what they changed.

commented

Regardless, it was an established practice of the Buildcraft Team to record the original author of the file. This is a change that should not have been done without the consent of the entire team.

commented

This information is still recorded, just go the start of Github history for the file. Why go through the trouble of keeps the headers when Github does the tracking automatically?

commented

Respect maybe? Besides, there have been many times when I've moved code around to the point that the GitHub history no longer reflects the original owner. The Github history is also clunky.