BuildCraft|Core

BuildCraft|Core

7M Downloads

Add configuration to allow to remove certain block recipes

SpaceToad opened this issue · 24 comments

commented

That was possible in the previous BuildCraft, would be useful to have this kind of feature back.

commented

I'm willing to work on this.

commented

Thanks @TXX59 - you got it :-)

commented

Can I do it in a separate config file?

(The layout would then be main.conf, recipes.conf and the blueprints folder.)

commented

There's no reason to make it a separate config file at this stage, that would be inconsistent. There's already various lists of exclusion in the current one, this just follows the same scheme.

commented

Should I add gate, wire etc recipes in the config option?

commented

Through their items, yes. That makes sense.

commented

No probs. Take your time :-)

commented

Okay. Almost done, will submit in about 20 mins. (Apologies for my slow pace.)

commented

Okay, I'm finished. I'll be submitting the PR right now. However, there is an NPE. I will need someone to fix that, because I just can't.

commented

Is that an NPE related to your change? Anyway, we'll need at least the actual problem to comment ;-)

commented

It... is. Once I submit the PR, I'll also post the crash report in a comment.

commented

Ok - will review it when submitted.

commented

Hi @TXX59 - do you have an ETA on this one? Just to know if it should get in 6.0.11 or be pushed to 6.0.12.

commented

Wrong issue in the check-in, sorry about that.

commented

@TXX59 - sounds perfect!

commented

I should be able to finish in time for 6.0.11, in other words today.

Connected by Motorola

SpaceToad [email protected] wrote:

Hi @TXX59 - do you have an ETA on this one? Just to know if it should get in 6.0.11 or be pushed to 6.0.12.


Reply to this email directly or view it on GitHub.

commented

I can now confirm that I've started work on it again. However, I see two possible options:

  1. Add a separate config file for recipes
  2. Merge recipe configuration with the main file and rename it to buildcraft.conf. There is no other config file, just the blueprints folder.

(I'll probably change the default blueprint directory to the main game folder.)

Connected by Motorola

SpaceToad [email protected] wrote:

@TXX59 - sounds perfect!


Reply to this email directly or view it on GitHub.

commented

I'm not sure I understand, but let me re-specify: all we want here is a list of blocks and items excluded from survival, as a list in main.conf. The implementation of this exclusion will be to avoid loading the recipes. Please don't change anything else.

commented

Alright.

commented

By the way, what is this buildToolBlock in BuildCraftBuilders?

commented

It's the red block that is sent to destroy other blocks.

commented

Nevermind: second time around, will be submitted tomorrow.

commented

@SpaceToad Can I not add the option for the pump? Whenever I add it, there is a NullPointerException coming from it.

commented

@TXX59 I'm taking over this one. Will fix the pump issue along with it.