BuildCraft|Core

BuildCraft|Core

7M Downloads

Gates extensions not passed to client

SpaceToad opened this issue ยท 4 comments

commented

They don't seem to show anymore or allow action - but when dropped they are indeed dropped as proper gates with extensions.

commented

Some more intel on that one - seems like there are some synchronization issues between client and server. Working on it,

commented

I'm not too late? I suggest couple improvements for core systems of buildcraft.

  • @NBTData annotation for storing data into NBT (like @networkdata for network updates)
  • Make @networkdata works for updating object's client state (possibly only some group of @NetworkDatas should be synchronized.

btw about this issue: gates only not synchronized in gui

commented

You're not too late, in particular since you're commenting on orthogonal issues ;-)

the NBTData idea is a great one. I've never managed to get myself to implement it, but it makes a lot of sense. Two requirements to ensure retro-compatbility:

  • we should be able to add alternative names on read
  • we should be able to force a given NBT type on read (e.g. short instead of int).

NetworkData is already allowing to update client states (see https://github.com/BuildCraft/BuildCraft/blob/6.0.x/common/buildcraft/core/TileBuildCraft.java#L94-L99). Not all the code is using it at the moment, but it's the intention. RPC are here to complement network synchronization model, when message passing is more efficient.

commented

This one is actually fixed - should have been closed earlier.