BuildCraft|Core

BuildCraft|Core

7M Downloads

add in game config support

AEnterprise opened this issue ยท 7 comments

commented

In forge for minecraft 1.7.10 you can now modify the configurations of the mods directly from in the game (in the mod list) so users don't need to modify the config files anymore. This is only possible if the mod supports it. The code for this isn't hard at all (i recently did it for my mod (AEnterprise/Buildcraft-Additions@5359571) so if you guys want i can take a look intro adding this for buildcraft as well and do a pr (unless somebody else wants to do it)

So @SpaceToad if you want me to do this, just let me know and assign this issue to me then

commented

@AEnterprise it'd be great if you could give it the first shot on the 6.1 branch. Thanks for the help!

commented

no problem, will do it later today but as this is something that just reads all things based on the categories you parse it this should also be possible to do on the 6.0 branch, merge intro 6.1 and then add new categories intro it if there are additional, up to you though, i could do both seperatly to if you want

commented

This is a new feature. In order to limit bug introduction, we're trying to avoid addition of new features except on some specific cases. Let's keep this one on 6.1 - there's nothing that can't be done with the old system in 6.0.

commented

ok, will do

commented

@SpaceToad not as easy as i thought, the config stuff is pretty easy itself, but to apply it to buildcraft i'll need to move around some variable and almost completely rewrite the reading in of the config file

commented

@AEnterprise so definitely make sense to do in 6.1 ;-)

commented

@SpaceToad there are no major changes, it's just that the reading and asigning should be on the same line so forge can detect if something changed (already did a pr for this)