BuildCraft|Core

BuildCraft|Core

7M Downloads

Crash caused by ItemFacade

liach opened this issue ยท 9 comments

commented

Crash Report:
https://gist.github.com/anonymous/9fe524491c8aea875488
On a server I got this serious bug. The server uses Cauldron, of course with essential plugin, and I had the "give" command access. I installed NEI on client and click one of those facades of pipes. Suddenly it crashed, gave me the Crash Report above. I tried to log into the server again but it crashed and gave me the same crash report. Maybe NEI sent a command of vanilla to the server and caused issues, but client shouldn't crash again.
Glad to see Asie to fix.

commented

NEI has many issues with BC facades, use the regular creative tab or assembly table

commented

But the biggest problem is that once I login, Minecraft crashes, and I cannot play any more. How to solve this problem?

commented

Remove your player.dat, but you will lose your inventory. It is in world/players/UUID.dat where UUID is your unique login ID, displayed in server logs upon login attempt

commented

So ask the server operator to remove my players/UUID.dat?

commented

Yes

commented

Thx and close

commented

After try this does not work. I logged on the server and saw the itemFacade. Crash report says this line has problem:
140 public String getItemStackDisplayName(ItemStack itemstack) {
141 switch (getFacadeType(itemstack)) {
142 case Basic:
143 return super.getItemStackDisplayName(itemstack) + ": " + getFacadeStateDisplayName(getFacadeStates(itemstack)[0]);
144 case Phased:
145 return StringUtils.localize("item.FacadePhased.name");
146 default:
147 return "";
148 }
149 }
line 143, getItemStackDisplayName(itemstack) had the "arrayoutofbound" exception. Could you please add a try {} catch {} ?

commented

It seems that a check will be useful. And I hope to see an update for this.

commented

@liach - No, the problem is that NEI does not keep NBT tags from facades. This needs a better fix.