BuildCraft|Core

BuildCraft|Core

7M Downloads

Chunk Load loop Buildcraft + ChickenChunks

Slind14 opened this issue ยท 11 comments

commented

https://gist.githubusercontent.com/Slind14/e2055d743d3e8276c61a/raw/d4dce8a96beddf0a96074ae9df28353c70a538c4/gistfile1.txt

The source seems to be more likely buildcraft or the chunkloading of minecraft than chicken chunks.

@asiekierka let us know what you think.

commented

@Slind14 - could you try with this build? http://asie.pl/bc630-chunk.jar

commented

Would you mind telling me what you changed? I don't have a way to reproduce it. While it happens often I can't fully reproduce it :(

commented

@Slind14 - I made the code check if a chunk exists (thus, is loaded) before running operations on it. This, in theory, should fix the issue. However, you shouldn't run this BC 6.3.0 build permamently - it's bugged in places.

We'll see when I release, I guess.

commented

if you let me know where I need to add this check or push the commit I could patch it into the buildcraft version I use and let you know within 6-12 hours if it worked.

commented

@Slind14 - here you go!

commented

Looks like copy pasting the class is enough for testing. Thank you very much for the quick fix.

commented

not a single crash/soe yet, I guess it did solve the issue. I'll let you in case it appears again.

commented

alright. It still happens. :(
https://gist.github.com/Slind14/92c6faa99ca93dd614bb

https://gist.github.com/Slind14/1bb033d5e6534a14029d#file-gistfile1-txt-L76
78 -> 76 on the linked de-compiled class

edit: just noticed the linked jar is different than the commit.

testing now with self compiled class

commented

@asiekierka I also noticed that the chunkproperty cache does not get deleted on chunk unload, this might cause a memory leak on the long term.

commented

@Slind14 - any new notes? I believe this might be an issue with ChickenChunks itself. We need @Chicken-Bones to help out here, he knows this better than I do.

commented

it works fine, I guess the issue can be closed. I even experienced the same issue with an own mod and checking if the chunk was loaded worked there, too.