Liquid dupe bug with BlockTank
mezz opened this issue ยท 5 comments
When your inventory is full and you put a fluid into a tank using a container registered with the FluidContainerRegistry, the tank will accept the liquid and then return "false" from onBlockActivated
.
For forestry cans and capsules, this means the capsule is not consumed.
For ic2 cells, this means the cell dumps its contents on the ground.
Either way, duplicated liquid is added to the tank.
I think the best solution is to throw the empty container on the ground and return true.
Relevant Code:
Found while investigating: ForestryMC/ForestryMC#425
If you don't accept the liquid, the ic2 cells will act like the tank is full and dump their water on the ground (super confusing when it happens).
I think it would be more user-friendly to accept the liquid and drop the empty can on the ground.
If the BuildCraft tank sees that the player's inventory is full and says "sorry I can't accept liquid",
IC2 cell says "hey this thing can't accept liquid, I'll happily dump my contents here because I'm basically a bucket"
Now I'm dying in a pool of hot liquid here
even though the tank looked like it had space
@mezz I know, I know. It's just... Eh. I'll fix it now.