BuildCraft|Core

BuildCraft|Core

7M Downloads

Refinery not accepting Biomass

Megistus opened this issue ยท 21 comments

commented

I have two refineries that have been, and continue to operate converting biomass. I tried placing a new refinery to add to my production and it will not accept biomass. Looking at the GUI of the Refinery, the input slots are already filled in with a Black, undefined, item and will not let me replace it with biomass. Apparently, it looks as if the bug fix for oil not filling both slots has ensured that no other fluid can be used in the refinery if it did not already have the fluid in it prior to the update. I attempted to left and right click the input slots with a bucket of biomass to no effect. The black item in the slot would disappear momentarily and return.

Buildcraft 6.4.2
Forge 1291

commented

Excellent!

commented

Expect a new release tomorrow.

commented

Whoops!

commented

@warlordjones - could you fix it? you wrote the code and it would spare me some free time.

commented

Cannot reproduce.

commented

Perhaps a mod that Megistus uses is overwriting oil, which causes "BuildCraftEnergy.fluidOil" to be an invalid liquid.

commented

Well, for whatever reason, my configuration / collection of mods is not allowing this to occur. I suspect - as I have not done any coding in a number of years - that tileRefinery.class is not getting past this.tanks[0].setAcceptedFluid(BuildCraftEnergy.fluidOil);
this.tanks[1].setAcceptedFluid(BuildCraftEnergy.fluidOil);

What ever coding method that clears this entry and allows the addition of biomass is not being reached.

Though, as I am thinking about it, could this possibly be due to using Java 8, and an incompatibility from that version and what is coded?

commented

Not sure why those lines are even there, they don't appear to do anything...

commented

It looks as if when I place down a refinery, that those lines of code are getting run. Of course, that is an assumption as I don't have a dev environment set up that can track what is getting run and what isn't.

commented

I know they are being run, but in my dev environment my refinery accepts biofuel with or without those lines...

commented

@psxlover - yes!

@Megistus - are you using Artifice?

@warlordjones - rewrite the code to query the fluid registry for "oil"; in fact, replace all direct references to blockOil with that.

commented

Hrm - those lines just aren't needed...it works with and without, and doesn't reintroduce the bug I was trying to fix. Will do though

commented

@warlordjones - Artifice (with BC's help) can overwrite our oil - this could be the reason.

commented

I'm not directly checking for oil, I don't think, I'm checking in the RefineryRecipes, but I'll see.

commented

@warlordjones - try adding Artifice and see if the issue appears, as fluidOil would be null in that case

commented

Yup, doing that

commented

I am not using Artifice mod

commented

Oh.

commented

Buildcraft oil works as expected. Oil fills both tanks and shows up in the GUI. Processes into fuel.
However, when placing down a new refinery, where the left and right slot should be empty, it displays oil. Thus, it looks as if the refinery is initialized with a fluid (oil) ensuring that no other fluid can be added, even though there was no fluid introduced. The refinery thinks it has oil, even though it does not.

commented

Looks like my previous commit should fix that then.

commented

Just a quick thanks. The removal of those lines of code fixed the issue with no apparent issues caused. Thanks again!