TOO Bad Compitability with MineFactory Reloaded
ishitatsuyuki opened this issue ยท 11 comments
Yup, BuildCraft 7.0.13.
The pipes doesn't connect to some of the machines in MineFactory Reloaded.
A famous mod (by CoFH :) called Thermal Expansion does it very well.
Comparasion:
Liquid router doesn't connect but works well though.
Thermal Expansion and MFR's developers work together (they're part of one team), so that is no surprise. I'll look into it.
@asiekierka - we didn't collude on this one in any way. This would seem to be on your end with how BC pipes detect valid tiles.
Your power pipes should be looking for either IEnergyReceiver or IEnergyProvider. My guess is they're looking for IEnergyHandler.
For Fluids, you should just look for IFluidHandler. Don't do a tank check, since there are mods without internal tanks that still handle fluids correctly.
@KingLemming - Except I am?
For fluids, see https://github.com/BuildCraft/BuildCraft/blob/6.5.x/common/buildcraft/transport/PipeTransportFluids.java#L216-L218
For power, see https://github.com/BuildCraft/BuildCraft/blob/6.5.x/common/buildcraft/transport/PipeTransportPower.java#L116-L123 (I check for both because there was this long period of time in which your changes broke literally everything - by accident and coremod misuse, but still - and I wanted to work with both versions of the RF API)
@ishitatsuyuki , @KingLemming - could not reproduce. This is with CodeChickenCore, NEI, Factorization, CoFHCore, MFR and BuildCraft 7.0.16, though 7.0.13 changed nothing in that part of the code. (Are you using Cauldron, FastCraft, CoFHTweaks, OptiFine, etc.?)
I got CoFHTweaks (or optifine when previous reproduce) but I don't think they do something bad.
And Thermal Expansion of course.
Yeah, tested with:
MC 1.7.10
forge-1.7.10-10.13.4.1448
buildcraft-7.0.17
buildcraft-compat-7.0.9
CoFHCore-[1.7.10]3.0.3-303
MineFactoryReloaded-[1.7.10]2.8.0-104
magicalcrops-4.0.0Beta5 and MFR Compat 1.2.1
Optfine 1.7.10 HD U C1
Slaughterhouse and Golden Kinesis Pipe not connecting
disabled optifine, magical crops, mfr compat, still not connecting
disabled bc compat, connects
enabled bc compat, doesn't connect
skyboy said something about the bc compat breaking default connection override to RF-providers, which apparently MFR uses?
Interesting, on the phone right now so it's a little difficult to make a issue for me over at BCCompat - will look tonight if other made the report with reference to this
Seems like im not the only one that have this issue, reported it over at MFR but was told on IRC that it was a BC issue.
