Fix all your getStackInSlotOnClosing

Question

Fix all your getStackInSlotOnClosing

SoniEx2 opened this issue 9 years ago · 6 comments

SoniEx2 commented 9 years ago

Like wtf? https://github.com/BuildCraft/BuildCraft/blob/6.5.x/common/buildcraft/robotics/EntityRobot.java#L696-L699

See also ModCoderPack/MCPBot-Issues#32

SoniEx2 · Answer 1 · 2015-09-11T20:40:26.000Z

I think you forgot to updateClientSlot...?

asiekierka · Answer 2 · 2015-09-11T17:13:03.000Z

That's the correct behaviour in EntityRobot, you know? Think.

SoniEx2 · Answer 3 · 2015-09-11T17:34:56.000Z

But it's inconsistent with getStackInSlot(i) followed by setInventorySlotContents(i, null)!

hea3ven · Answer 4 · 2015-09-11T17:42:42.000Z

Yeah, var1 is supposed to be the slot number, splitting the stack in the inventory by it is weird. That said, no one should call this method, and even more, now that I think about it, there may be some of the robot boards assume they have complete control over the robot's inventory and might break if you forcefully add/remove stacks from it.

asiekierka · Answer 5 · 2015-09-11T18:26:38.000Z

@hea3ven - wait, that's the slot number!? okay that's a bug then wow

asiekierka · Answer 6 · 2015-09-11T18:27:35.000Z

Fixed. Not bothering to mention in changelog as nobody will hit this ever.

Share to