BuildCraft|Core

BuildCraft|Core

7M Downloads

Rare chance of a pipe being placed rendering incorrectly

LuigiHutch opened this issue ยท 8 comments

commented

BC 7.2.0

There is a rare chance of a pipe being placed not updating.
2016-03-14_09 47 44

To produce this, I just kept placing pipes and it has a rare chance or occuring. That is supposed to be gold transport pipe and it was not over a chunk boundry. It does not update with a block update.

commented

Same happens after world load with already existing pipes - worth noting that it is not only visual thing as it also brakes gates GUI.
2016-03-14_11 21 37

commented

@MrGraphic - this does not happen to me. Could you try with just BuildCraft?

commented

@asiekierka it happens sometimes. Also happens without other mods in env but it is very very rare. Leaving area of interest and returning fixes this, same for forcing rerender via pipe wires, same for world reload.

commented

Yeah its rare and odd and I'm not sure if its a render problem or a networking problem- could be stuff being sent at the wrong time or it could be stuff not updating.

commented

Reproduced the rare chance bit, marking as bug. I suspect threaded networking.

commented

Yeah I scrapped the entire BC networking system in favour of forge's own SimpleNetworkHandler and IMessage, which works much better. Oh, and I auto-handle ALL messages on the main thread, a tick or 2 later than normal so this sort of thing shouldn't happen in 8.0.x (and MCMP handles all init stuff anyway :) )

commented

this can probably be closed as fixed then

commented

since MC 1.8 messages are handled on a different thread then the main thread, i know BC does special things for networking but probably related

IThreadListener.addScheduledTaskis to execute code on the main thread, the minecraft client instance or the server worldserver both implement that