BuildCraft|Core

BuildCraft|Core

7M Downloads

Builders not working above y=128 in the end

toddnollan opened this issue · 11 comments

commented

Builders, placed in the end, when given a Blueprint that vertically extends above y=128 or placed themselves above y=128 will not build any blocks above that line. They will instead fire the red 'breaking' blocks at the places where blocks are required, as if the spaces were filled.

Found in private pack, tested in both singleplayer and multiplayer, in both creative and survival.
BC version 7.1.14, not listed as fixed in .15 or .16

Confirmed existing in FTB Infinity
Additionally, Fillers seem to think something is there.
Filling each block (by hand) seems to fix the issue for that particular area.

commented

Confirmed, in the nether as well.

commented

This is what happen when I use it on nether even I turn off the excavate.
2016-04-16_15 15 17
In fact there are nothing.

commented

@MrGTout interesting bug... have you confirmed this with only buildcraft installed?

commented

Yes

发自我的 iPhone

在 Apr 17, 2016,4:13 AM,panda2134 [email protected] 写道:

@MrGTout interesting bug... have you confirmed this with only buildcraft installed?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

commented

@panda2134 @MrGTout Great...
http://www.mcbbs.net/thread-586890-1-1.html
Another thread that complain about builder not functioning in Nether where y>128.

Buildcraft version is unknown...

commented

Is the chunk loaded?
If it is, is it loaded by a player or a chunk loader block (What mod is the block from?)?

commented

@MrDiamond123 if you can see the chunk then the player is chunkloading it

is this bug still present in the latest 1.8.9 version of BC?

commented

Yes. Its caused by

    public DimensionProperty(World iWorld, WorldProperty iProp) {
        world = iWorld;
        worldHeight = iWorld.getActualHeight(); // This line
        world.addWorldAccess(this);
        worldProperty = iProp;
    }

WorldProvider:

    public int getActualHeight() // We use this
    {
        return hasNoSky ? 128 : 256;
    }

    public int getHeight() // but may want to use this instead
    {
        return 256;
    }
commented

The question is whether we want to continue using getActualHeight or use getHeight. The only place where getActualHeight is used over getHeight in vanilla is for portals. (Its actually used all over BC for all patterns and robot bombers)

commented

if only portals use it i'd say BC shouldn't be using it, it's a portals only function that has an incorrect naming

commented

fixed on 1.8.9 so can be closed