BuildCraft|Core

BuildCraft|Core

Mods
7M Downloads

Is BuildCraft using the "simulate" parameter of "IEnergyProvider#extractEnergy" the wrong way around?

Lordmau5 opened this issue ยท 1 comments

commented

Basically this part in the PipePowerWood class:

BuildCraft/common/buildcraft/transport/pipes/PipePowerWood.java

Lines 111 to 115 in 91ed2af

if (source instanceof IEnergyProvider) {
int energyExtracted = battery.addEnergy(0, ((IEnergyProvider) source).extractEnergy(o.getOpposite(), energyMaxExtract, true),
false);
((IEnergyProvider) source).extractEnergy(o.getOpposite(), energyExtracted, true);
}

The CoFH API states the proper usage of the "simulate" parameter here:

BuildCraft/api/cofh/api/energy/IEnergyProvider.java

Lines 23 to 24 in 91ed2af

* @param simulate
* If TRUE, the extraction will only be simulated.

Perhaps someone mixed it up with the IFluidHandler's "doFill" or "doDrain" parameter?

commented

Oh, yes! Thank you very much!