BuildCraft|Core

BuildCraft|Core

7M Downloads

Facades have broken code

tahg opened this issue ยท 12 comments

commented

Not sure what the issue is. Seems to only involve extrautils resources, but I'll keep an eye out.
See trace here: https://pastebin.com/3x69sjRv

and here for a slightly different trace: https://pastebin.com/8XPUiyER

commented

Can you please say your ExtraUtilities version?

commented

extrautils2-1.11.2-1.4.1

commented

ExtraUtilities methods PropertyEnumSimple.parseValue doesn't seem to mirror PropertyEnumSimple.getName(prop) - the map creation does this:

this.nameToValue.put(t.toString(), t);
this.propertyNames.put(t, t.toString().toLowerCase());
commented

I think it's important for the facades to be resistant to all kinds of nasty errors, ideally disabling and blacklisting the facade when an error is encountered.

commented

OK, will do.

commented

Sounds good, we will also try to forward the ExtraUtilities2 error to RWTema.

commented

thanks

commented

Yes, but that doesn't mean that there aren't issues elsewhere as well. I can fix the first log issue, hopefully that fixes the second logged issue as well.

commented

Same issue, only involving Vanilla and BC, when trying to open the creative search GUI
https://pastebin.com/La8aPAb9

commented

@tahg That's using more than just vanilla + BC...

commented

@tahg Can you remove extra utils 2 and try to reproduce it?

commented

Ok, removing ExU fixes the issue with the creative bar. I guess it just wasn't apparent in the stack trace. Not sure if that ultimately fixes the first two issues, but probably.