Odd Out of Bounds exception on world save - 1.7.10

Question

Odd Out of Bounds exception on world save - 1.7.10

Opened this issue 8 years ago · 4 comments

Deleted user commented 8 years ago

Hi Guys,

Hope you still support 1.7.10!!

Saw this with your latest version pop up in the server logs, not sure what the problem was exactly though.
Using v7.1.21.

[05:38:03 WARN]: Exception in thread "Thread-58"
[05:38:03 WARN]: java.lang.ArrayIndexOutOfBoundsException: 7005
[05:38:03 WARN]:        at gnu.trove.set.hash.TLongHashSet.toArray(TLongHashSet.java:167)
[05:38:03 WARN]:        at buildcraft.robotics.map.MapWorld.save(MapWorld.java:88)
[05:38:03 WARN]:        at buildcraft.robotics.map.MapManager.saveAllWorlds(MapManager.java:131)
[05:38:03 WARN]:        at buildcraft.robotics.map.MapManager.run(MapManager.java:144)
[05:38:03 WARN]:        at java.lang.Thread.run(Thread.java:745)

AlexIIL · Answer 1 · 2017-05-25T09:47:12.000Z

Looks like we don't synchronise here https://github.com/BuildCraft/BuildCraft/blob/7.1.x/common/buildcraft/robotics/map/MapWorld.java#L143. As this is probably a concurrency issue there's probably not a good way of reproducing this to test.

asiekierka · Answer 2 · 2017-05-25T15:09:02.000Z

I think throwing a synchronization in there would help, though.

AlexIIL · Answer 3 · 2017-05-31T16:53:47.000Z

Should be fixed in 7.1.22

Deleted user · Answer 4 · 2017-06-01T00:37:02.000Z

Thanks guys - really appreciate it :)

Share to